Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 279721 - MySqlCatalogDatabase.refresh() does not
Summary: MySqlCatalogDatabase.refresh() does not
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Enablement (show other bugs)
Version: 1.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: future   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-09 20:20 EDT by Brian Vosburgh CLA
Modified: 2012-05-18 13:15 EDT (History)
2 users (show)

See Also:

Attachments
Possible patch (1.34 KB, patch)
2009-08-27 18:27 EDT, Brian Fitzpatrick CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Vosburgh CLA 2009-06-09 20:20:13 EDT 
When I call MySqlCatalogDatabase.refresh(), the single schema held by the database is not refreshed. The refresh event is sent to the appropriate listeners; but when a listener comes back to the database to get the new schemas, they are stale.

Notes: The MySqlCatalogDatabase flags 'schemasLoaded' and 'catalogsLoaded' seem to be unused - they are never set to Boolean.TRUE. The flag 'schemasLoaded' is set to Boolean.FALSE in refresh(), but the schemas are still loaded....
Comment 1 Brian Fitzpatrick CLA 2009-06-10 11:26:10 EDT 
ok. I'll take a look at this
Comment 2 Brian Fitzpatrick CLA 2009-08-27 18:27:29 EDT 
Created attachment 145871 [details]
Possible patch

This should fix the setting of the flags accordingly... If you have a chance to test, that would be great. Works fine here, but I can't quite repro the issue you have either.
Comment 3 Brian Fitzpatrick CLA 2009-09-02 11:29:57 EDT 
Bumping to 1.7.2. 

Brian V - if you get a chance to test it, we'll try and get it into an early build of 1.7.2 or whatever we're doing for Helios
Comment 4 Brian Fitzpatrick CLA 2010-05-18 11:26:15 EDT 
Once again, this is going to have to get pushed to "future" because we just don't have the manpower. Sorry.
Comment 5 Pierre Queinnec CLA 2012-05-18 13:15:04 EDT 
Hi guys, I committed the fix, with an added modification on super.refresh().
This works fine here and refreshes correctly (I tested on SP and UDF modifications). Brian (V.) could you comment further if that's not the correct fix you were expecting? Many thanks.

See http://git.eclipse.org/c/datatools/org.eclipse.datatools.enablement.mysql.git/commit/?id=026b00d06ac8ba593abef046f3bbcb91fe712fd6