Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 279544 - add a "Learn More" link to connector categories
Summary: add a "Learn More" link to connector categories
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272621
  Show dependency tree
 
Reported: 2009-06-08 20:34 EDT by Wesley Coelho CLA
Modified: 2009-06-16 00:05 EDT (History)
3 users (show)

See Also:


Attachments
mylyn/context/zip (53.79 KB, application/octet-stream)
2009-06-10 16:38 EDT, David Green CLA
no flags Details
borders on info buttons (27.86 KB, image/png)
2009-06-11 11:36 EDT, Mik Kersten CLA
no flags Details
mylyn/context/zip (71.53 KB, application/octet-stream)
2009-06-11 23:28 EDT, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley Coelho CLA 2009-06-08 20:34:33 EDT
Currently, only the connector entries have a "Learn more..." link. It would be helpful if categories had a similar link so more information could be provided about the purpose or significance of a category.
Comment 1 Mik Kersten CLA 2009-06-09 16:43:35 EDT
David: This seems high priority because we will need to have a way to link in pages like http://wiki.eclipse.org/Mylyn_Extensions from the Community listing.  In general, I think that every category will need some sort of more detailed explanation, including the Eclipse.org one and the one that we're planning for the Tasktop Certified program.  Is it feasible for us to add the same sort of "i" link and popup for categories?
Comment 2 David Green CLA 2009-06-09 16:58:16 EDT
(In reply to comment #1)
> Is it feasible for us to add the same sort of "i" link and popup for categories?

Really anything is possible.  Just specify how you want it to work... I'll make it happen.

Some things to consider:

* 'learn more' link and 'i' might make the UI look busy
* consider permitting HTML anchors in the category description text
* should links open a browser or popup information provided in the categoryDescriptor?
Comment 3 Mik Kersten CLA 2009-06-09 22:22:09 EDT
It seems like the easiest thing to do right now is to make the "i" mechanism work for categories.  It has a nice preview with "Learn More" link on popup, etc.  We may not need a screenshot for it, but that image area could be used for larger images or logos.  So it seems like the requirements are almost identical.  I realize it will make the UI look a bit more busy, but I think it will be worthwhile in terms of ensuring that people can learn about the category without needing to fall into a web browser.
Comment 4 David Green CLA 2009-06-10 16:37:57 EDT
Initial implementation complete, some minor UI issues with button appearance remain.
Comment 5 David Green CLA 2009-06-10 16:38:02 EDT
Created attachment 138850 [details]
mylyn/context/zip
Comment 6 David Green CLA 2009-06-10 18:52:56 EDT
done
Comment 7 David Green CLA 2009-06-10 18:58:10 EDT
buttons look funny on Linux
Comment 8 David Green CLA 2009-06-10 19:05:38 EDT
look fixed on Linux
Comment 9 Mik Kersten CLA 2009-06-11 11:35:42 EDT
David: I'm seeing some bad rendering and need to get a screenshot of the discovery out asap.  Could you revert the change for now?  Will attach screenshot.
Comment 10 Mik Kersten CLA 2009-06-11 11:36:30 EDT
Created attachment 138944 [details]
borders on info buttons
Comment 11 David Green CLA 2009-06-11 11:46:19 EDT
(In reply to comment #9)
> David: I'm seeing some bad rendering and need to get a screenshot of the
> discovery out asap.  Could you revert the change for now? 

Changes reverted
Comment 12 Mik Kersten CLA 2009-06-11 12:01:42 EDT
Thanks!  Always annoying how the cross-platform behavior is different when transparencies come into play.
Comment 13 Steffen Pingel CLA 2009-06-11 17:23:57 EDT
David, it looks like the toolbar version had the border flag set: ToolBar toolBar = new ToolBar(connectorContainer, SWT.FLAT | SWT.BORDER). Can you try removing that?
Comment 14 David Green CLA 2009-06-11 19:47:38 EDT
(In reply to comment #13)
> David, it looks like the toolbar version had the border flag set

Oops!  I had set a border to debug some layout issues that I was having.  Thanks for pointing that out!

Fix committed.... could you give it a go on Linux and Windows?
Comment 15 Steffen Pingel CLA 2009-06-11 21:22:49 EDT
Thanks. Works fine on Linux and Windows. 

The only thing that I find slightly weird is that categories require a screenshot (what would we put there?). Would it make sense to make the Tooltip for categories smaller if no screenshot is specified?
Comment 16 David Green CLA 2009-06-11 23:01:21 EDT
(In reply to comment #15)
> Thanks. Works fine on Linux and Windows.
> 
> The only thing that I find slightly weird is that categories require a
> screenshot (what would we put there?). 

Well, it's not actually required, just allowed.  Good point about when would we use it -- but allowing it gives us better code reusability.

> Would it make sense to make the Tooltip for categories smaller if no screenshot is specified?

Yes, that makes sense.
Comment 17 David Green CLA 2009-06-11 23:28:02 EDT
I've reworked the layout so that if an image is not provided the tooltip is less wide, and the height is only as high as needed to fit all of the provided text.  As per Steffen's suggestion I've moved the 'Learn More' link up so that both the summary and the link fit into the same vertical space as the image.  This means that there is one less line available for summary text, which could affect content for some connectors.

Please take a look and let me know what you think.  It's pretty easy to move the link back down if we need to.
Comment 18 David Green CLA 2009-06-11 23:28:08 EDT
Created attachment 138997 [details]
mylyn/context/zip
Comment 19 Steffen Pingel CLA 2009-06-11 23:48:43 EDT
Looks good. I would align the Learn More link at the bottom though if there is a screenshot.
Comment 20 David Green CLA 2009-06-16 00:05:30 EDT
(In reply to comment #19)
> I would align the Learn More link at the bottom though if there is a screenshot.

Done.