Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 279238 - [design] Toolbars for multiple views don't work
Summary: [design] Toolbars for multiple views don't work
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 262576
  Show dependency tree
 
Reported: 2009-06-05 07:09 EDT by Holger Staudacher CLA
Modified: 2009-06-16 03:30 EDT (History)
1 user (show)

See Also:

Attachments
Temporary solution (7.35 KB, patch)
2009-06-05 07:09 EDT, Holger Staudacher CLA 		no flags Details | Diff
FInal Solution (16.18 KB, patch)
2009-06-07 12:06 EDT, Holger Staudacher CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2009-06-05 07:09:00 EDT 
If the workbench contains multiple views, the configuration behaviour and the view toolbars don't work correctly. The presentation produce more toolbars then necessary.
Comment 1 Holger Staudacher CLA 2009-06-05 07:09:53 EDT 
Created attachment 138391 [details]
Temporary solution
Comment 2 Holger Staudacher CLA 2009-06-05 07:11:29 EDT 
The attached, temporary solution works only if the multiple views are in the same IFolderLayout. A more general solution is in progress.
Comment 3 Holger Staudacher CLA 2009-06-07 12:06:46 EDT 
Created attachment 138511 [details]
FInal Solution

This patch contains changes in the ConfigurableStack and consider the toolbars for multiple views.
Comment 4 Rüdiger Herrmann CLA 2009-06-08 14:26:22 EDT 
+1 to commit the patch
Comment 5 Holger Staudacher CLA 2009-06-08 14:40:31 EDT 
committed.
Comment 6 Hasan Ceylan CLA 2009-06-15 12:13:36 EDT 
I still see some problems:

1) By default actions and view menu is invisible
2) Menubars are placed underneath the title which wastes a lot of space.

Hasan
Comment 7 Holger Staudacher CLA 2009-06-15 13:10:22 EDT 
Hi Hasan,
the default value for all actions is invisible. This results in a cleaner UI. I think we will provide a solution to make all action visible in a later release. I opened a bug for this, see bug 280299.
Comment 8 Hasan Ceylan CLA 2009-06-16 02:29:34 EDT 
How about placing the actions next to the action configuration button?
Otherwise a lot of space is wasted.

I can work the other one out myself by patching.
Comment 9 Hasan Ceylan CLA 2009-06-16 02:36:07 EDT 
I have spotted one more problem:

Drop down menu for the action is somewhat cached and only updated updated when the view of the action is deactivated and reactivated. It works fine with the default RCP design...
Comment 10 Rüdiger Herrmann CLA 2009-06-16 03:28:44 EDT 
(In reply to comment #8)
> How about placing the actions next to the action configuration button?
> Otherwise a lot of space is wasted.
The downside is that the actions would "float around" when the view stack is resized and there is no definitive location to find them.
Please file a separate enhancement request if you wish to discuss such a change.
Comment 11 Rüdiger Herrmann CLA 2009-06-16 03:30:20 EDT 
(In reply to comment #9)
> I have spotted one more problem:
> Drop down menu for the action is somewhat cached and only updated updated when
> the view of the action is deactivated and reactivated. It works fine with the
> default RCP design...
Could you please file a separate bug report so that we can track the progress on this issue? Ideally with some code or a step-by-step guide to reproduce.
Thanks
Rüdiger