Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 278872 - consider including the "Add more connectors..." button in the new task dialog
Summary: consider including the "Add more connectors..." button in the new task dialog
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272621
  Show dependency tree
 
Reported: 2009-06-02 17:23 EDT by Wesley Coelho CLA
Modified: 2009-06-15 19:14 EDT (History)
3 users (show)

See Also:

Attachments
mylyn/context/zip (36.07 KB, application/octet-stream)
2009-06-09 22:45 EDT, Mik Kersten CLA 		no flags Details
icon for Add Task Repository button (1.36 KB, patch)
2009-06-15 19:13 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (39.48 KB, application/octet-stream)
2009-06-15 19:13 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley Coelho CLA 2009-06-02 17:23:09 EDT 
The ability to add new connectors via the discovery mechanism would be more accessible if the "Add more connectors..." button appeared next to the "Add task repository..." button in the New Task dialog.
Comment 1 Wesley Coelho CLA 2009-06-09 18:54:13 EDT 
Mik, any thoughts on the priority of this?
Comment 2 Mik Kersten CLA 2009-06-09 22:45:33 EDT 
Done.

David, Steffen: Would be great if you could sanity check.  I was wondering if I shouldn't be copying the action handling code.
Comment 3 Mik Kersten CLA 2009-06-09 22:45:38 EDT 
Created attachment 138740 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2009-06-10 03:20:48 EDT 
Looks good. It would be nice if this was extracted to a common method but I am fine with leaving it for now.
Comment 5 Mik Kersten CLA 2009-06-10 11:58:27 EDT 
Yeah, it's hard to say given that it's effectively a big constructor that I copied.  But what we could do is make a reusable button class or composite that has the action, or something like that.
Comment 6 Steffen Pingel CLA 2009-06-12 19:13:39 EDT 
Reopening for discussion: What I find odd is that after installing connectors from the New Task dialog and going back after the restart I still don't see the connectors in the list (because I haven't created a repository, yet). I'm leaning towards removing the button until we have a mechanism to prompt the user to create a repository, e.g. from the Welcome screen.
Comment 7 Wesley Coelho CLA 2009-06-12 19:22:41 EDT 
I think it's important for the button to be there so that this feature is discoverable. Without that button I think many users wouldn't be aware that you can easily add more connectors.
Comment 8 Steffen Pingel CLA 2009-06-15 19:13:00 EDT 
Created attachment 139222 [details]
icon for Add Task Repository button
Comment 9 Steffen Pingel CLA 2009-06-15 19:13:03 EDT 
Created attachment 139223 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2009-06-15 19:14:11 EDT 
I have added an icon to make the buttons look more consistent. I still have some concerns with the work-flow and the button showing up in multiple places but we can revisit this for the next release.