Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 278622 - Patch: Port of Agent Controller build to Mac OSX
Summary: Patch: Port of Agent Controller build to Mac OSX
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Klicnik CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: closed471
Keywords:
Depends on:
Blocks: 68111
  Show dependency tree
 
Reported: 2009-06-01 10:33 EDT by Paul Klicnik CLA
Modified: 2016-05-05 10:59 EDT (History)
2 users (show)

See Also:
jgwest: review+

Attachments
patch for build on macosx (149.60 KB, patch)
2009-06-01 10:33 EDT, Paul Klicnik CLA 		pklicnik: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Klicnik CLA 2009-06-01 10:33:07 EDT 
Created attachment 137849 [details]
patch for build on macosx

The patches posted to fix the build system for the Mac OSX port all contained an error in the linking stage. Posted a patch to repair this

Hopefully after this patch is committed, contributors will be able to check out the code from CVS and compile/begin working without much hassle.
Comment 1 Paul Klicnik CLA 2009-06-01 10:36:16 EDT 
Overview of the changes:
1. Separated out the make files. That is, the mac platform now has it's own separate make files which can be identified by the _mac suffix
2. Fixed the linking error in all the make files 
3. In the 'top level' build_tptp_ac.script file, added a Mac target and created a new variable so that we can switch between gmake and make (depending on the platform)
Comment 2 Kathy Chan CLA 2009-06-01 10:39:23 EDT 
Jonathan,

Please review and commit after TPTP 4.6 is done.
Comment 3 Jonathan West CLA 2009-06-01 11:05:09 EDT 
Patch is good.
Comment 4 Spundun Bhatt CLA 2009-06-01 23:11:53 EDT 
wonderful patch. I was hoping we could do this, similar to the solaris port. This probably replaces the build patch from the tarred patch I posted on #68111
Comment 5 Jonathan West CLA 2009-08-06 22:32:54 EDT 
Patch committed to HEAD.
Comment 6 Kathy Chan CLA 2010-11-18 18:47:28 EST 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.