Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 277970 - implement a single-selection attribute editor with image support
Summary: implement a single-selection attribute editor with image support
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: David Shepherd CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272092
  Show dependency tree
 
Reported: 2009-05-26 19:46 EDT by Steffen Pingel CLA
Modified: 2009-06-01 19:25 EDT (History)
0 users

See Also:

Attachments
A first draft at a patch to address this problem (10.12 KB, patch)
2009-05-26 21:11 EDT, David Shepherd CLA 		no flags Details | Diff
mylyn/context/zip (60.89 KB, application/octet-stream)
2009-05-26 22:46 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2009-05-26 19:46:02 EDT 
If space for an attribute editor is limited such as in the header of the Task Editor it would be helpful to have an attribute editor that used an image for displaying the current value of an attribute. The editor should have a drop-down for selecting values from a popup menu.
Comment 1 David Shepherd CLA 2009-05-26 21:11:44 EDT 
Created attachment 137255 [details]
A first draft at a patch to address this problem
Comment 2 Steffen Pingel CLA 2009-05-26 22:45:53 EDT 
Thanks David. I have committed the patch with a few modifications: The menu was not disposed when re-created, tooltips were not properly updated and refresh was not implemented for read-only mode. There was also some dead code that I removed. Please review my changes.
Comment 3 Steffen Pingel CLA 2009-05-26 22:46:04 EDT 
Created attachment 137258 [details]
mylyn/context/zip
Comment 4 David Shepherd CLA 2009-05-27 11:42:11 EDT 
I reviewed the changes and they look good.

One remaining issue: the drop-down affordance (the downwards pointing triangle to the right of the icon) is black, which stands out more than normal attribute editors, which use a grey triangle.  Should the color be changed to grey?  This doesn't seem high priority.
Comment 5 Steffen Pingel CLA 2009-05-27 16:20:18 EDT 
The triangle is provided by the platform and dependent on the OS theme. I don't think we should change it.