277783 – Http service should not use 8859_1 alias on S60

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 277783 - Http service should not use 8859_1 alias on S60

Summary: Http service should not use 8859_1 alias on S60

Status:	RESOLVED FIXED

Alias:	None

Product:	Equinox
Classification:	Eclipse Project
Component:	Compendium (show other bugs)
Version:	unspecified
Hardware:	Other SymbianOS S60

Importance:	P3 normal (vote)
Target Milestone:	3.5.1
Assignee:	Thomas Watson
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-05-25 22:38 EDT by Jiun-Yang Hsu
Modified:	2009-07-28 15:25 EDT (History)
CC List:	5 users (show)

See Also:

Flags:	simon_kaegi: review+

Attachments
The patch file to fix this. (1.98 KB, patch) 2009-05-25 22:39 EDT, Jiun-Yang Hsu	tjwatson: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jiun-Yang Hsu

2009-05-25 22:38:04 EDT

This alias does not work on S60 devices. The only valid alias is ISO-8859-1, and this also works on all other platforms. Http service should use the correct alias.

Comment 1 Jiun-Yang Hsu

2009-05-25 22:39:29 EDT

Created attachment 137103 [details]
The patch file to fix this.

Comment 2 Eric Hsu

2009-05-26 03:11:27 EDT

We are trying to use OSGi http service (org.eclipse.equinox.http) in Nokia S60 system. After investigation, we found Nokia S60 is only able to digest ISO-8859-1 alias. We have verified the http service with ISO-8859-1 alias works well in many platforms ( windows mobile, and Windows family, etc). Is it possible to use ISO-8859-1 alias for org.eclipse.equinox.http in Eclipse? We also attached our patch file in this bug. Thanks a lot.

Comment 3 Thomas Watson

2009-05-26 11:20:56 EDT

Interesting.  So 8859_1 is not listed as a valid alias in http://www.iana.org/assignments/character-sets I think we should be using "ISO-8859_1" in this case.

Comment 4 Mark Rogalski

2009-05-26 11:55:21 EDT

If I read that doc right, the preferred alias is: "ISO-8859-1". That is the one that the most platforms understand.

Comment 5 Thomas Watson

2009-05-26 12:14:23 EDT

(In reply to comment #4)
> If I read that doc right, the preferred alias is: "ISO-8859-1". That is the one
> that the most platforms understand. 
> 

yup I had a typo in my comment: "ISO-8859-1" should be used, just like the patch suggests.

Comment 6 Thomas Watson

2009-07-28 14:46:53 EDT

I released the patch to HEAD for 3.6.  Simon, can you review for 3.5.1?

Comment 7 Simon Kaegi

2009-07-28 14:53:10 EDT

Looks good.

Comment 8 Thomas Watson

2009-07-28 15:25:30 EDT

Fix released for 3.5.1.