Community
Participate
Working Groups
I will be attaching a patch to fix the following issues: 1. When running the "Fix Copyrights" action, only files where the company name matches the one from the template are being updated 2. When running the "Fix Copyrights" action, the last commit comment is not checked for the keyword "copyright" to avoid ripple effects caused by the last copyright update 3. Spaces being inserted when running the "Eclipse/IBM Fix Copyrights" action (i.e. the patch includes the changes from bug 276255 (attachment 136624 [details])
Created attachment 137038 [details] patch
It's worth noting that the comment check is very inefficient in the sense that it performs 1 round trip per file. The tool does support the ability for the repository provider to perform some up-front calculation and cache those results for later use. For CVS, it would be possible to prompt for a tag to compare against (e.g. the tag for the previous release) and then only update the copy right year for those files that have changes since the last release. This would mean P round trips (one per project) instead of F (one per file).
I have successfully run the patched tool on all of Platform UI and am happy with the changes. (It did take a long time though, you are right about the gross inefficiency Michael :-)
In the patch, the copyright hasn't been updated for two of the changed files ;)
I ran with this patch on all Equinox p2 content, which found another ~100 files that were not updated in my last pass. I reviewed each change and they all looked good. I think with these fixes, we'll be able to retire the "IBM fix copyrights" tool for good (in 3.6).
(In reply to comment #4) > In the patch, the copyright hasn't been updated for two of the changed files ;) Of course not, the tool will do that for me, won't it? ;-)
The slow performance captured by bug 216797.
Patch works great for me. Only thing I notice is that it doesn't touch any feature.properties files because it think there's two copyrights in there (message is printed). But this can go into a separate bug. I'd like to see this patch released for 3.5.
Martin, if you would like this patch approved for 3.5, you need one component lead and two committers to approve the patch.
Alright then, rules must be followed :) We disucssed this in the PMC today and decided to bring it up in the arch call, but I had to leave after half an hour so I could not bring it up any more. Anyways, I'm a committer so that's one; Boris, Johnn, Daniel, Steve, McQ any +1's ? It looks like we've all successfully used this for our copyright updates.
+1 from me.
Patched released and tagged for I-build.
From bug 234623 comment 6: > I didn't actually try this, but from looking at the patch for bug 277735 (which > has been released after my working fix), it pretty much looks like that patch > just removed the check that made sure nothing is overwritten! Could those who wrote or reviewed the patch for this bug please make sure that bug 234623 gets fixed before people start using the copyright tool for 3.6?
