Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 277716 - Method names fix in org.eclipse.stp.sca.osoa.java
Summary: Method names fix in org.eclipse.stp.sca.osoa.java
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sca (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-25 11:31 EDT by Lionel Seinturier CLA
Modified: 2017-03-30 14:20 EDT (History)
2 users (show)

See Also:
Stephane.Drapeau: iplog+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lionel Seinturier CLA 2009-05-25 11:31:35 EDT
Build ID: 3.4

Steps To Reproduce:
For the org.eclipse.stp.sca.osoa.java module.

1/ In interface Conversation: shouldn't method getConversionID() be spelled getConversationID()?

Version 1.00 of the specs (Java Client and Implementation Specification) says:

----------------------------
public interface Conversation {
  Object getConversionID();
  void end();
}

The ServiceReference (sic!!) Java interface has the following methods:
* getConversationID() – Returns the identifier for this conversation. If a user-defined identity had been supplied for this reference then its value will be returned; otherwise the identity generated by the system when the conversation was initiated will be returned.
* end() – Ends this conversation.
----------------------------

The code snippet declares getConversionID, but the comment provides the more intuitive version getConversationID. I guess we can assume that the code snippet contains a typo and that the correct version is getConversationID.

BTW it is also clear that the comment contains a typo: one should read "The Conversation Java interface" and not "The ServiceReference Java interface".


2/ Shouldn't class NoRegistredCallbackException be spelled NoRegisteredCallbackException?


3/ It would be nice if the ConversationEndedException, ServiceRuntimeException and ServiceUnavailableException exceptions would declare four constructors to override the ones declared in RuntimeException:
- no arg
- (String)
- (String,Throwable)
- (Throwable)


More information:
Comment 1 Stephane Drapeau CLA 2009-05-25 11:40:24 EDT
Fixed. Commit #3168
Comment 2 Vincent Zurczak CLA 2011-03-25 08:31:28 EDT
Close old bugs.