This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 277713 - Crash (probably opening dialog with progress reporting in it)
Summary: Crash (probably opening dialog with progress reporting in it)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.5 RC4   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 277012 278421 278975 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-25 11:20 EDT by Pascal Rapicault CLA
Modified: 2009-06-04 11:12 EDT (History)
10 users (show)

See Also:
Mike_Wilson: review+
steve_northover: review+
eclipse.felipe: review+
gheorghe: review+

Attachments
Log file of the crash (55.86 KB, application/octet-stream)
2009-05-25 11:21 EDT, Pascal Rapicault CLA 		no flags Details
Log of an additional crash (53.84 KB, application/octet-stream)
2009-05-25 11:31 EDT, Pascal Rapicault CLA 		no flags Details
crash log (84.38 KB, text/plain)
2009-06-01 20:07 EDT, Leo Dos Santos CLA 		no flags Details
fix (2.04 KB, patch)
2009-06-02 17:35 EDT, Silenio Quarti CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-05-25 11:20:48 EDT 
3.5 rc2
I was trying to uninstall something (Eclipse > About > Installation details) and at the moment where I would have expected a dialog reporting progress to open, eclipse crashed.
Comment 1 Pascal Rapicault CLA 2009-05-25 11:21:31 EDT 
Created attachment 137021 [details]
Log file of the crash
Comment 2 Kevin Barnes CLA 2009-05-25 11:30:57 EDT 
Crash report looks like bug 277012. 
Is this reproducible?
Comment 3 Pascal Rapicault CLA 2009-05-25 11:31:37 EDT 
Created attachment 137022 [details]
Log of an additional crash
Comment 4 Kevin Barnes CLA 2009-05-25 12:07:06 EDT 
What were you uninstalling? Do you crash everytime? Can you crash my mac?
Comment 5 Steve Northover CLA 2009-05-25 15:27:52 EDT 
Need to know, can you make the crash happen every time?
Comment 6 Pascal Rapicault CLA 2009-05-25 21:39:41 EDT 
Don't remember what I was uninstalling but I don't think this has to do with it. Can't reproduce systematically. I have tried again without success.
Comment 7 Steve Northover CLA 2009-06-01 11:22:48 EDT 
*** Bug 278421 has been marked as a duplicate of this bug. ***
Comment 8 Leo Dos Santos CLA 2009-06-01 20:07:12 EDT 
Created attachment 137921 [details]
crash log

I just experienced an Eclipse crash doing a routing workspace build. The Java portion of the stack trace differs a little bit from the ones already posted, but the native stack for thread-0 is identical.
Comment 9 Silenio Quarti CLA 2009-06-02 10:47:27 EDT 
We have a theory that the crash happens when an item from the Apple menu is selected (such as About, Preferences, Quit). 


Can you all confirm that you were selecting a item from that menu when you crashed?
Comment 10 Leo Dos Santos CLA 2009-06-02 13:33:25 EDT 
I think I may have tried to bring up the preferences dialog via keyboard before the crash.
Comment 11 Silenio Quarti CLA 2009-06-02 17:35:09 EDT 
Created attachment 138065 [details]
fix
Comment 12 Silenio Quarti CLA 2009-06-03 10:19:02 EDT 
We have a strategy to release temporary memory kept by NSAutoreleasePool's in a timely manner. This is need to be able to run applications that do not run the event loop often enough (for example, junit tests). The top of the stack of pools is released when we determine it is safe to do so. The global callback entry count has to be zero to be safe. This test was introduced for this bug#276131.

The problem is that the counter was not being incremented/decremented in a thread safe manner and pools were release when they should not. We are fixing this by calling atomic functions to increment/decrement the counter.
Comment 13 Silenio Quarti CLA 2009-06-03 10:33:31 EDT 
*** Bug 277012 has been marked as a duplicate of this bug. ***
Comment 14 Steve Northover CLA 2009-06-03 11:43:36 EDT 
NOTE:  Even though callback.c is shared on all platforms, the fix is #define'd such that it is only running on cocoa.
Comment 15 Silenio Quarti CLA 2009-06-03 15:07:59 EDT 
Fixed > 20090603
Comment 16 Felipe Heidrich CLA 2009-06-04 11:12:51 EDT 
*** Bug 278975 has been marked as a duplicate of this bug. ***