Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 277671 - Implement background gradients
Summary: Implement background gradients
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: plan-version=1.3 plan-status=committe...
Keywords:
Depends on:
Blocks: 279640 279663
  Show dependency tree
 
Reported: 2009-05-25 07:46 EDT by Tim Buschtoens CLA
Modified: 2009-08-04 16:07 EDT (History)
6 users (show)

See Also:


Attachments
CVS Patch (14.92 KB, patch)
2009-05-25 07:46 EDT, Tim Buschtoens CLA
no flags Details | Diff
Enable control background gradient through IControlAdapter (31.29 KB, patch)
2009-06-05 10:00 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
Enable control background gradient through IControlAdapter (62.43 KB, patch)
2009-06-08 06:28 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
Enable background gradient in Forms. (9.61 KB, patch)
2009-06-09 03:12 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
Enable control background gradient through IWidgetGraphicsAdapter (67.09 KB, patch)
2009-06-15 03:07 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
New GfxMixin (45.52 KB, patch)
2009-06-22 11:49 EDT, Tim Buschtoens CLA
no flags Details | Diff
Updated patch with latest version of GfxMixin and CSS support (for both gradients and rounded borders) (114.24 KB, patch)
2009-06-29 10:44 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
Changed Scale default theme with rounded border and background gradient (for demo purpose only). (2.79 KB, patch)
2009-06-29 10:53 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
Updated patch: code refactoring and JUnit test included (131.60 KB, patch)
2009-07-02 02:58 EDT, Ivan Furnadjiev CLA
no flags Details | Diff
enable gradient and rounded border css (17.63 KB, patch)
2009-07-13 12:11 EDT, Tim Buschtoens CLA
rsternberg: iplog+
Details | Diff
example theme (10.40 KB, text/plain)
2009-07-13 12:13 EDT, Tim Buschtoens CLA
no flags Details
Fixes problem with group-dimension (1.03 KB, patch)
2009-07-14 06:04 EDT, Tim Buschtoens CLA
rsternberg: iplog+
Details | Diff
Enableds gradients for more widgets (17.55 KB, patch)
2009-07-17 13:08 EDT, Tim Buschtoens CLA
rsternberg: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2009-05-25 07:46:16 EDT
Created attachment 136995 [details]
CVS Patch

Currently, the "gradientMixin" mixin for qooxdoo-widgets provides a themeable "gradient"-property, that renders a gradient background in SVG/VML. 

Example for use in appearances:

style : function( states ) {
  var result = {};
  if( states.over ) {        
    result.gradient = [ "blue", "green"];
  } else {
    result.gradient = null;
  }
}
Comment 1 Ivan Furnadjiev CLA 2009-06-05 10:00:15 EDT
Created attachment 138405 [details]
Enable control background gradient through IControlAdapter

This patch includes:
1. GradientMixin
2. RAP part modifications to utilize the GradientMixin
3. JUnit test for backgroundGradient rendering.
4. Controls Demo -> CompositeTab modification - "Background Gradient" button added.
Comment 2 Ivan Furnadjiev CLA 2009-06-08 06:28:28 EDT
Created attachment 138559 [details]
Enable control background gradient through IControlAdapter

Updated pacth with latest version of GfxMixin.js.
Comment 3 Ivan Furnadjiev CLA 2009-06-09 03:12:09 EDT
Created attachment 138652 [details]
Enable background gradient in Forms.

The background gradient in Section and FormHeading is implemented.
Comment 4 Benjamin Muskalla CLA 2009-06-09 11:45:56 EDT
Note: The gradient code should be moved to Widget instead of Control as we need it for Items, Menus, etc too.
Comment 5 Ivan Furnadjiev CLA 2009-06-15 03:07:21 EDT
Created attachment 139144 [details]
Enable control background gradient through IWidgetGraphicsAdapter

The code for background gradient is moved to IWidgetGraphicsAdapter and WidgetLCAUtil.
Comment 6 Tim Buschtoens CLA 2009-06-22 11:49:42 EDT
Created attachment 139767 [details]
New GfxMixin

Now supports intermediate values. API changed, instead of "[ startcolor, stopcolor ]", it now is "[ [ position, color ], [ position, color], etc ]". As a result, "[ null, null ]" is also no longer valid, only "null". The position must be a number between 0 and 1. The values must be sort in an ascending order, and at leat 0 and 1 have to be defined. Therefore, the first item must be "[0, color]", the last "[1, color]". The values are NOT checked, an invalid structure might lead to any kind of result. 

Rounded borders are also included in the mixin. See bug 278743, attachment 138426 [details].
Comment 7 Ivan Furnadjiev CLA 2009-06-29 10:44:20 EDT
Created attachment 140381 [details]
Updated patch with latest version of GfxMixin and CSS support (for both gradients and rounded borders)
Comment 8 Ivan Furnadjiev CLA 2009-06-29 10:53:55 EDT
Created attachment 140385 [details]
Changed Scale default theme with rounded border and background gradient (for demo purpose only).
Comment 9 Ivan Furnadjiev CLA 2009-07-02 02:58:23 EDT
Created attachment 140656 [details]
Updated patch: code refactoring and JUnit test included
Comment 10 Ivan Furnadjiev CLA 2009-07-06 03:48:27 EDT
Changes are in CVS HEAD.
Comment 11 Tim Buschtoens CLA 2009-07-13 12:11:32 EDT
Created attachment 141433 [details]
enable gradient and rounded border css

enables the use of css property "border-radius:" and "background-image:gradient". Also sovles the resizeing-problem with Titlebar and Group.
Comment 12 Tim Buschtoens CLA 2009-07-13 12:13:16 EDT
Created attachment 141434 [details]
example theme

A quick example-theme using all new properties.
Comment 13 Tim Buschtoens CLA 2009-07-14 06:04:38 EDT
Created attachment 141496 [details]
Fixes problem with group-dimension

Patch 141433 attampted to solve a layout-problem with group-frames and rounded borders. However, this also created a new bug that set the wrong dimension for group-frames, even if no rounded borders are used. This is now solved.
Comment 14 Ivan Furnadjiev CLA 2009-07-14 14:54:52 EDT
With patch 141496 the Group rounded border ( not Group-Frame border ) is not visualized at all ( if you use theme.css from attachment 141434 [details] ).
Comment 15 Tim Buschtoens CLA 2009-07-17 13:08:03 EDT
Created attachment 141899 [details]
Enableds gradients for more widgets

Enables css-gradients for Shell, Composite, Label, CLabel, TableColumn, TreeColumn, TabItem, CTabItem and also rounded borders for Shell.