Comment 1 Jacek Pospychala 2009-05-25 04:46:16 EDT

let's keep it simple for start. try extend this class org.eclipse.jface.dialogs.InputDialog 

Comment 2 Wojciech Galanciak 2009-05-28 11:08:58 EDT

Created attachment 137504 [details]
simple connection dialog

I added first version of connection dialog. It extends simple ImputDialog. There is also partly implemented address validation.

Comment 3 Wojciech Galanciak 2009-07-11 17:56:12 EDT

Created attachment 141361 [details]
updated version of connection dialog

It's updated version of the connection dialog. It's a patch for pde-incubator/osgimonitoring/plugins/org.eclipse.pde.runtime. Main change is a simpler validation which only checks that url is not null and it's correct URI constructor argument syntax.

Comment 4 Jacek Pospychala 2009-07-13 19:31:42 EDT

Thanks Wojciech. Change looks simple. 

1. Do we really need a separate class for ConnectionDialog? Why not just create anonymous IInputValidator class, like:

InputValidator validator = new IInputValidator() {
  public String isValid(String url) { ... }
};
InputDialog dialog = new InputDialog(Display.getCurrent().getActiveShell(), PDERuntimeMessages.RegistryView_connectAction_label, PDERuntimeMessages.RegistryView_enterURL, validator);


2. I wonder what would happen if a RegistryModel got disconnected. Would Plug-in registry automatically turn back to local connection? (We might solve this in separate bug, please open one for that.)

3. Second, it'd be good to show the "Connect" option only when connectors other than "local" are available, to keep User interface simple. To do that we could check how much extensions are registered with our extension point. (This is minor)

Comment 5 Wojciech Galanciak 2009-07-14 04:57:29 EDT

Created attachment 141491 [details]
updated connection dialog

This is updated version of connection dialog. I've added anonymous IInputValidator definition as argument for InputDialog constructor instead of additional ConnectionDialog class. Additionaly, it checks a number of extensions registered with our extension point and shows "Connect" option only if there is at least one available.

Comment 6 Jacek Pospychala 2009-07-21 02:26:33 EDT

I have simplified the validation a bit. We might think about improving the dialog to give a hint or use some default URL to the user.

Thanks Wojtek, good job!

FIXED.