Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 277553 - [fwkadmin] installfolder calculation is wrong when installArea is null
Summary: [fwkadmin] installfolder calculation is wrong when installArea is null
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 284630 285743 286921 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-22 17:37 EDT by Simon Kaegi CLA
Modified: 2019-10-02 19:39 EDT (History)
6 users (show)

See Also:

Attachments
proposed patch (1.29 KB, patch)
2009-05-24 22:53 EDT, Simon Kaegi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2009-05-22 17:37:09 EDT 
The install folder calculation done in EclipseLauncherParser.read is incorrect when the installArea is null.

The call to launcherData.getFwJar().getParentFile().toURI() needs to also check and discard an additional level if the folder name is "plugins".
Comment 1 Simon Kaegi CLA 2009-05-24 22:53:06 EDT 
Created attachment 136937 [details]
proposed patch

The problem is easily reproduced. Take an install and remove the -startup and --launcher.library entries from an eclipse.ini and launch. If you try to install anything you'll get an error when intializing the manipulator.

This patch corrects the logic so that it's consistent with other places where we're doing the same calculation.
Comment 2 Simon Kaegi CLA 2009-05-24 23:00:22 EDT 
...in case it's not evident I should add that with the patch the install is carried out correctly. Flagging for RC3 to discuss however this might be too late.
Comment 3 Simon Kaegi CLA 2009-05-25 16:17:01 EDT 
Patch is probably fine but this area is very sensitive -- moving to 3.5.1
Comment 4 Simon Kaegi CLA 2009-08-19 13:38:23 EDT 
Talking to Pascal we've decided to defer for 3.5.1 and put it in 3.6 HEAD for now. Taking this bug back...
Comment 5 Andrew Niefer CLA 2009-10-14 15:03:17 EDT 
*** Bug 285743 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Niefer CLA 2009-10-14 15:03:34 EDT 
*** Bug 286921 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Niefer CLA 2009-10-14 15:03:46 EDT 
*** Bug 284630 has been marked as a duplicate of this bug. ***
Comment 8 Andrew Niefer CLA 2009-10-14 15:12:04 EDT 
fixed
Comment 9 Pascal Rapicault CLA 2013-02-11 17:25:32 EST 
I've reverted this change because I believe it broke the shared install case (see bug #400326). Note that the automated tests for shared install and this code had been released on the same day.
Comment 10 Eclipse Genie CLA 2019-10-02 19:39:43 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.