Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 277275 - support update sites without P2 meta-data
Summary: support update sites without P2 meta-data
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272621
  Show dependency tree
 
Reported: 2009-05-21 02:16 EDT by Steffen Pingel CLA
Modified: 2009-05-28 19:41 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2009-05-21 02:16:57 EDT
The discovery component checks for a content.jar file to verify if an update site is valid. This breaks update sites that do not provide P2 meta-data but still have a site.xml. Since this is still a common scenario the validation code should also check for a site.xml if the content.jar is not available and as a fall-back check for content.xml in case the meta-data is not compressed. These checks should be cheap if HEAD requests are issued in the same HTTP connection.
Comment 1 David Green CLA 2009-05-21 13:44:50 EDT
from call: verify sites with/without metadata, but don't filter them outright.  Present them differently in UI
Comment 2 David Green CLA 2009-05-21 20:58:45 EDT
Site verification has been modified.  Also as per call, components are not filtered out if the site is unavailable: some kind of indication in the UI will show the user that the connector is probably unavailable.
Comment 3 David Green CLA 2009-05-22 00:43:21 EDT
Mik how would you like to display connectors where the update site URL was either unavailable or had some other kind of problem?  It was suggested that a warning decoration icon be used.  That sounds good to me -- but where would the decoration appear.  Would we also provide a tooltip on it to indicate what the warning is about?
Comment 4 Mik Kersten CLA 2009-05-27 00:46:32 EDT
How about disabling that row (preferrably by setting it's style to SWT.GRAY since that looks prettier) and putting in a warning on the wizard page that says something like "Some connectors sites could not be contacted and appear in gray". 
Comment 5 David Green CLA 2009-05-28 11:34:43 EDT
in latest row is now disabled.  I couldn't find SWT.GRAY, so instead set the foreground color.

I tried the wizard warning, however the result was less than optimal: the wizard page instructions are no longer visible.  Instead a warning dialog popup occurs if an attempt is made to select any of the disabled items.  Please let me know if you think this is a good idea.
Comment 6 Mik Kersten CLA 2009-05-28 19:41:08 EDT
Sounds good.