Comment 1 Bryan Hunt 2009-05-21 00:21:07 EDT

Forgot to mention that if you close the wizard and re-open it, the Finish button will be properly enabled ... debug carefully :)

Comment 2 Pascal Rapicault 2009-05-21 07:15:21 EDT

I think this may have been fixed in last night I build. You can grab it from http://download.eclipse.org/eclipse/updates/3.5-I-builds

Comment 3 Bryan Hunt 2009-05-22 15:36:13 EDT

I just ran into this problem on build I20090521-2000 trying to install LWJGL

Comment 4 Susan McCourt 2009-05-22 16:22:19 EDT

Bryan, are you on Carbon?

The fixes we've done during the RC1/RC2 address timing problems/interactions with validating/revalidating the install while changing pages.  We had problems when a new page was added during the button transition.

But not having the finish button enable when you select the license radio button is very odd.  I just double checked the code here and we are simply setting a selection listener on a radio button 

acceptButton.addSelectionListener(new SelectionAdapter() {
			public void widgetSelected(SelectionEvent e) {
				setPageComplete(acceptButton.getSelection());
			}
		});

For the finish button not to enable, the accept button's selection would have to not be set upon receiving the event.  Steve, does this sound possible?

Another possibility is the event flow in the decline button case.  We have

declineButton.addSelectionListener(new SelectionAdapter() {
			public void widgetSelected(SelectionEvent e) {
				setPageComplete(acceptButton.getSelection());
			}
		});

This could cause a problem if you select the accept button, and the decline button was getting an event for its deselection before the accept button was set.  However, if this were the case, I would expect the accept button to get a corresponding positive selection event when it did get set...

So I think there would have to be an ordering problem in the event flow for this to fail.

Comment 5 Bryan Hunt 2009-05-22 17:03:13 EDT

Susan, I'm using Cocoa ... I've updated the OS field to properly reflect this.

Comment 6 Susan McCourt 2009-05-22 17:50:37 EDT

meant to cc: Steve before...any known/funky event issues with radios on Cocoa?

Comment 7 Steve Northover 2009-05-22 18:06:11 EDT

It is possible that there are issues.  Silenio and/or Kevin are the guys you want.

Comment 8 Susan McCourt 2009-05-22 18:12:53 EDT

I won't have time to write a snippet until next week (Mon is a US holiday)...but my suspicion is that the selection events and button states are not in synch for radios on Cocoa.

The wizard is AcceptLicensesWizardPage.

Comment 9 Kevin Barnes 2009-05-25 11:06:04 EDT

I'm not aware of issues with radio buttons on cocoa. My simple test case has the same behavior on carbon and cocoa.

	public static void main(String[] args) {
		try {
		final Display display = new Display();
		Shell shell = new Shell(display);
		shell.setLayout(new RowLayout());
		
		Listener listener = new Listener() {
			public void handleEvent(Event event) {
				Button button = (Button) event.widget;
				System.out.println(button + " " + button.getSelection());
			}
		};
		Button button = new Button(shell, SWT.RADIO);
		button.setText("ONE");
		button.addListener(SWT.Selection, listener);
		Button button1 = new Button(shell, SWT.RADIO);
		button1.setText("TWO");
		button1.addListener(SWT.Selection, listener);
		Button button2 = new Button(shell, SWT.RADIO);
		button2.setText("THREE");
		button2.addListener(SWT.Selection, listener);
		

		shell.setSize(1000, 800);
		shell.open();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
		} catch (Exception e) {
			e.printStackTrace();
		}
	}

Comment 10 Susan McCourt 2009-06-15 19:50:42 EDT

*** Bug 280360 has been marked as a duplicate of this bug. ***

Comment 11 Steffen Pingel 2009-06-15 20:08:41 EDT

I was seeing the same problem on Gtk.

Comment 12 Ian Bull 2009-06-16 22:49:51 EDT

(In reply to comment #11)
> I was seeing the same problem on Gtk.
> 
I have seen this too, but nothing I can reproduce.  When it happens (very rarely), it happens right after I add a site (in the install software view), select something, and install.  Like Bryan says, when you close the install software window and come back, the finish button is enabled. 

I'm on GTK.

Comment 13 Ketan Padegaonkar 2009-06-19 05:01:27 EDT

I'd filed bug 280881. That one seems like a dup of this from the surface, would someone confirm ?

Comment 14 Benjamin Cabé 2009-06-19 05:01:39 EDT

*** Bug 280881 has been marked as a duplicate of this bug. ***

Comment 15 Susan McCourt 2009-06-24 19:14:11 EDT

*** Bug 281410 has been marked as a duplicate of this bug. ***

Comment 16 Susan McCourt 2009-06-24 19:15:08 EDT

The dup bug was observed on Windows doing the following:
1. Install new software
2. Type the Subclipse site into the "Work with:" window:
http://subclipse.tigris.org/update_1.6.x
3.  Click next until you get to the Review Licenses page.  Select Required
libraries and under Subclipse select everything except for Mylin.
4.  Scroll through all licenses and Select "I accept ..." for all licenses.

Comment 17 John Arthorne 2009-07-15 12:35:59 EDT

*** Bug 283577 has been marked as a duplicate of this bug. ***

Comment 18 Jacek Pospychala 2009-08-05 04:06:37 EDT

hi I see this often on WinXP with Eclipse-3.5-SDK. Noticed that some of duplicates are also against WinXP so I'm expanding OS field to reflect that.

It appears randomly, on average in 1/3 of cases. Possible to workaround by stepping back few steps in Install wizard and going again thru it.
This time it happened when accessing http://eclipse.org/eclipse/platform-core/updates for first time.

If there's anything I can help with (trace options/breakpoint) to pin down this one, pls speak up.

Comment 19 John Arthorne 2009-08-10 14:39:26 EDT

*** Bug 286147 has been marked as a duplicate of this bug. ***

Comment 20 Urszula Krukar 2009-09-25 16:28:32 EDT

Happened to me just now (WinXp, build 20090621-0832). I have just added the site on the same dialog. Next and Finish button on 'Review Licenses' page were both disabled, what's more Cancel button did not work too. I could close the dialog either. I ended up killing Eclipse process because of this.

Site: http://update.eclemma.org/

Comment 21 Susan McCourt 2009-11-12 14:00:51 EST

fyi...the wizard code for 3.6M4 has been significantly cleaned up.  The pages are now all pre-created to avoid the "page is being created while user hits next" problem.  This also allowed us to remove the asyncExec code from bug 276356, which could have introduced a timing problem with button enablement.

I can't say for sure that I've fixed this problem, but I wouldn't be surprised if we saw it go away from M4 on.

Note that current p2 dev work is going on in a branch (as we move things to API) so this new code won't appear in I-builds right away.  It will be in M4.

Comment 22 Dale E. Moore 2009-11-22 14:16:45 EST

Thanks for all the wonderful work!

I'm running Ubuntu 9.10, VirtualBox 308ose, Windows 7, Helios and trying to install Ruby from http://download.eclipse.org/releases/helios; but, am never able to install Ruby.

Sometimes the Continue or Finish buttons do not enable.

Sometimes I get:

An error occurred while collecting items to be installed
	session context was:(profile=SDKProfile, phase=org.eclipse.equinox.internal.provisional.p2.engine.phases.Collect, operand=, action=).
	No repository found containing: osgi.bundle,org.eclipse.dltk,2.0.0.v20090827
	No repository found containing: osgi.bundle,org.eclipse.dltk.console,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.console.ui,2.0.0.v20090910-1958
	No repository found containing: osgi.bundle,org.eclipse.dltk.core,2.0.0.v20091110-1755
	No repository found containing: org.eclipse.update.feature,org.eclipse.dltk.core,2.0.0.v20090917-1518-7L--EAAoOQBUSiiBVyrP
	No repository found containing: osgi.bundle,org.eclipse.dltk.debug,2.0.0.v20091110-1532
	No repository found containing: osgi.bundle,org.eclipse.dltk.debug.ui,2.0.0.v20091110-0019
	No repository found containing: osgi.bundle,org.eclipse.dltk.formatter,2.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.launching,2.0.0.v20091110-0019
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby,1.0.0.v20090615-1430
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.abstractdebugger,1.0.0.v20090708-1856
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.activestatedebugger,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.basicdebugger,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.core,2.0.0.v200909260103
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.debug,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.debug.ui,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.fastdebugger,1.0.0.v20090730-1127
	No repository found containing: org.eclipse.update.feature,org.eclipse.dltk.ruby,2.0.0.v20090730-1514-7E--E_EkMO1NhokAVemF
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.formatter,2.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.launching,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.testing,1.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.dltk.ruby.ui,2.0.0.v20090815
	No repository found containing: osgi.bundle,org.eclipse.dltk.testing,1.0.0.v20090914-1703
	No repository found containing: osgi.bundle,org.eclipse.dltk.ui,2.0.0.v20091110-0019
	No repository found containing: osgi.bundle,org.eclipse.dltk.validators.core,1.0.0.v200909260103
	No repository found containing: osgi.bundle,org.eclipse.dltk.validators.externalchecker,1.0.0.v20090803-1754
	No repository found containing: osgi.bundle,org.eclipse.dltk.validators.ui,2.0.0.v20090730-1127
	No repository found containing: osgi.bundle,org.eclipse.emf.common,2.6.0.v200911060804
	No repository found containing: osgi.bundle,org.eclipse.emf.ecore,2.6.0.v200911060804
	No repository found containing: osgi.bundle,org.eclipse.emf.ecore.change,2.5.0.v200911060804
	No repository found containing: org.eclipse.update.feature,org.eclipse.emf.ecore,2.6.0.v200911060804
	No repository found containing: osgi.bundle,org.eclipse.emf.ecore.xmi,2.5.0.v200911060804

I thought y'all would want to know.
Dale E. Moore

Comment 23 Dale E. Moore 2009-11-22 16:45:26 EST

It works perfectly on Windows XP.

(In reply to comment #22)
> I'm running Ubuntu 9.10, VirtualBox 308ose, Windows 7, Helios and trying to
> install Ruby from http://download.eclipse.org/releases/helios; but, am never
> able to install Ruby.
...
> I thought y'all would want to know.
> Dale E. Moore

Comment 24 Pas 2009-12-29 16:44:20 EST

eclipse-SDK-I20091217-0819-win32-wpf on Windows 7 doesn't work.
 - the UI only shows the buttons when resized downward.
 - the next button isn't available (have to press Enter)
 - then after accepting the license, one has to go back to the first step, select the components again, then the finish button becomes available.

The non-WPF works like a charm.

(Though, I get tampered JAR errors, so it's broken somewhere deeper too. Tried to install Buckminster.)

Comment 25 Susan McCourt 2010-01-05 13:02:16 EST

(In reply to comment #24)
> eclipse-SDK-I20091217-0819-win32-wpf on Windows 7 doesn't work.
>  - the UI only shows the buttons when resized downward.
>  - the next button isn't available (have to press Enter)
>  - then after accepting the license, one has to go back to the first step,
> select the components again, then the finish button becomes available.
> 
> The non-WPF works like a charm.
> 
> (Though, I get tampered JAR errors, so it's broken somewhere deeper too. Tried
> to install Buckminster.)

Paz, the WPF issue is bug 276887.  I've cc'ed you on that one...

Comment 26 Susan McCourt 2010-01-05 14:06:04 EST

(In reply to comment #21)
> fyi...the wizard code for 3.6M4 has been significantly cleaned up.  The pages
> are now all pre-created to avoid the "page is being created while user hits
> next" problem.  This also allowed us to remove the asyncExec code from bug
> 276356, which could have introduced a timing problem with button enablement.
> 
> I can't say for sure that I've fixed this problem, but I wouldn't be surprised
> if we saw it go away from M4 on.
> 
> Note that current p2 dev work is going on in a branch (as we move things to
> API) so this new code won't appear in I-builds right away.  It will be in M4.

Something is still not right here.  Running branch build 32 (20091230)I reproduced the problem by:
- adding the Galileo site
- selected the category (and thus all the children) of PDE/API Tools Environment Descriptions, press next.  I got the install details page, but the next and finish buttons were not enabled.

I was able to fix it by going back to the first page, reselecting the repo, reselecting the category, pushing next, and then I could press finish.

Comment 27 Pascal Rapicault 2010-01-20 14:35:26 EST

I have steps to reproduce this on I20100119: 

- Vanilla eclipse, default p2 preferences
- Start eclipse once and add the 3.6-I-build repo
- Open the install dialog, disable the "show only latest version", disable "contact all update sites"

- Restart
- Go to Install software page
- Select the 3.6-I-build repo
- Go to the releng section and pick one version
- Click next to go into planning and as soon / fast as possible the plan is showed move to the next page, and select the accept button. 

You will notice that the finish button is not enabled.
Again in this scenario I have only been able to reproduce it going very fast in executing the steps and I have noticed that if I wait for the size to be loaded then it solves the problem.

Comment 28 Susan McCourt 2010-01-20 22:17:10 EST

(In reply to comment #27)
> I have steps to reproduce this on I20100119: 
> 
> - Vanilla eclipse, default p2 preferences
> - Start eclipse once and add the 3.6-I-build repo
> - Open the install dialog, disable the "show only latest version", disable
> "contact all update sites"
> 
> - Restart
> - Go to Install software page
> - Select the 3.6-I-build repo
> - Go to the releng section and pick one version
> - Click next to go into planning and as soon / fast as possible the plan is
> showed move to the next page, and select the accept button. 
> 
> You will notice that the finish button is not enabled.
> Again in this scenario I have only been able to reproduce it going very fast in
> executing the steps and I have noticed that if I wait for the size to be loaded
> then it solves the problem.

There is a chance that this bug is related to  Bug 300112.
We were getting artifact repo events when the sizing occurred, which caused the repo selection group to change selections.  With the selections lost, it's possible that the front page was now disabled which disabled the wizard.  Let's check this against I20100121-0800.

Comment 29 Susan McCourt 2010-01-21 19:47:50 EST

(In reply to comment #27)
> I have steps to reproduce this on I20100119: 
> 
> - Vanilla eclipse, default p2 preferences
> - Start eclipse once and add the 3.6-I-build repo
> - Open the install dialog, disable the "show only latest version", disable
> "contact all update sites"
> 
> - Restart
> - Go to Install software page
> - Select the 3.6-I-build repo
> - Go to the releng section and pick one version
> - Click next to go into planning and as soon / fast as possible the plan is
> showed move to the next page, and select the accept button. 
> 
> You will notice that the finish button is not enabled.
> Again in this scenario I have only been able to reproduce it going very fast in
> executing the steps and I have noticed that if I wait for the size to be loaded
> then it solves the problem.

I can't make this happen on I20100121-0800 + changes in HEAD.  
I verified that the finish button was enabled even before the size was calculated.  I went back to the resolution page to confirm this.  Finish was enabled still, then the size filled in, and finish was still enabled. 

I feel pretty confident that bug 300112 could cause this.  This needs to be verified against another build, and I'd feel more confident if Pascal tested it (in case he's faster than I am and something else is at play).

Comment 30 Susan McCourt 2010-02-18 14:15:06 EST

*** Bug 303168 has been marked as a duplicate of this bug. ***

Comment 31 Susan McCourt 2010-02-18 18:37:02 EST

It would appear this problem is still around (bug 303187 - I have not marked as a dup yet because I'm waiting to hear back from the bug reporter).

Something has just occurred to me, so I am reopening this bug.

I can understand how a change to the selected repo in the combo box could invalidate the first page selections, which would invalidate the entire wizard (no finish button enabled).  And I can understand how getting an unexpected (or in the case of bug 300112, incorrect) repo event while resolving an install could cause this.  I spent a good bit of time revisiting the UI event handling to prevent cases like bug 282176 in M5.  Typically these problems happen when a repo that has other repo references (such as a composite repo) is loaded for the very first time.

So I was expecting the "failing" cases to be repos that are composites or otherwise add enabled repo references.  Looking at the repo in the latest bug on this topic (bug 303187), it's just a simple legacy update site with no references at all.

Here's what I've just realized.
If *some other repo* that has these references is in the list of sites, and it has *never been loaded* before, and the user has

[x] Contact all update sites...

checkmarked, then the problem could still occur, because the planner will attempt to load all repositories, and the UI will receive repo addition/removal events associated with composite children that indeed could influence this case.

I think that this problem might be reproducible by doing something like:
- add a composite repo using the dialog in the install wizard.  It must be a repo not seen and not cached before.  Don't add it in the text box because we don't want to load it.
- also add the site you are trying to install from, and select what you are trying to install
- ensure [x] contact all sites is checked

The resolve will load sites and trigger child repo enable/disable events which could invalidate the combo. The wizard still advances to the next page and can go to the license page, but the "finish" button is not enabled because the first page no longer has selections....

If this is indeed the scenario, then we could fix this by either
- fixing event response in the combo (don't recall why repo enable/disable would lose selection, since we aren't removing the selected one)
- if there's some reason we can't avoid these we could use the UI event batching to ignore those events completely since once we resolve we don't need to respond to new repos...

Comment 32 Steve 2010-02-19 03:34:22 EST

Hi

I tried to re-create the steps I made yesterday, but no error this time.  For what it's worth, here are the details:-

From the URL:-

http://www.jboss.org/tools/download/update.html

I click to here:

http://www.jboss.org/tools/download

and copy link-location:

"JBoss Tools 3.1 :: Eclipse 3.5.0"

which is 


http://download.jboss.org/jbosstools/updates/development/

From Eclipse (Eclipse Java EE IDE for Web Developers. Build id: 20090920-1017) I select..

Help->Install New Software->Add...

NAME: JBoss Tools 3.5
LOCATION: http://download.jboss.org/jbosstools/updates/development/

Click [OK].

I see "pending..."


Then select all check boxes for...

  JBoss Tools - 3.1.0.v200912250601M-H198-CR1	
  JBoss Tools Integration For Maven, BIRT, TPTP - 3.1.0.v200912250601M-H198-CR1	
  JBoss Tools jBPM Tools - 3.1.0.v200912250601M-H198-CR1	
  JBoss Tools SDK - 3.1.0.v200912250601M-H198-CR1	

From the bottom of the "Available Software/Install" panel I checked box "Hide items that are already installed".

"Show latest.."
"Group by.."

and 

"Contact all updates..."

are pre-selected for me and I leave them like that.

[Next]

"The user operation is waiting for background work to complete"
"Calculating requirements and dependencies"

Sitting at 10% for a while then completion.

"Install Details" panel  appears telling me "The operation cannot be completed".

<quote>
Cannot complete the install because one or more required items could not be found.
  Software being installed: JBoss BIRT Integration 1.1.0.v200912250601M-H198-CR1 (org.jboss.tools.birt.feature.feature.group 1.1.0.v200912250601M-H198-CR1)
  Missing requirement: JBoss BIRT Integration 1.1.0.v200912250601M-H198-CR1 (org.jboss.tools.birt.feature.feature.group 1.1.0.v200912250601M-H198-CR1) requires 'org.eclipse.birt.integration.wtp.ui [2.5.1.v20090806]' but it could not be found
</quote>

So I select [Back].

Now back at the "Available Software/Install" panel again, I notice that the "root" tree boxes are un-selected (but the sub-tree branches -leaf nodes, are all selected).  Re-selecting the root node check box for 

"JBoss Tools Integration For Maven, BIRT, TPTP - 3.1.0.v200912250601M-H198-CR1"

and de-selecting it again (no tick) removes all tick boxes from the leaf node (unexpected that the root nodes are un-ticked but the leaf-nodes are ticked after using the previous [back] button).

So I now have only one root node selected:-

"JBoss Tools - 3.1.0.v200912250601M-H198-CR1"

and from within this I de-select Seam,Smooks and Struts leaf-nodes check boxes.

and click [Next] again.


(tick boxes at bottom of panel all selected as before (Hide Items...etc)).

Calculating dependencies.....

Install Details Panel asks me to review the items to be installed.  I see a list below and I select [Next] ([Finish] is blanked out).

I select the "Accept the terms.." button.

This time it's worked ok again, but the only difference in order of execution of events yesterday were the tick boxes I selected/de-selected yesterday trying to avoid dependency errors (unfortunately, I can't remember the exact sequence of boxes I ticked and un-ticked).

Not a lot of help I know, but the above events *might* help should the problem arise again (if I see it I'll post details and screenshots here).

Cheers
Steve

Comment 33 Steve 2010-02-19 03:39:49 EST

I just noticed Pascals comments about the [Next] button.  That's the same thing I saw.  I saw a [Next] appear and clicked on it.  Nothing happend so clicked on it a few times in quick succession.

Steve

Comment 34 Remy Suen 2010-03-01 10:25:58 EST

*** Bug 304215 has been marked as a duplicate of this bug. ***

Comment 35 Remy Suen 2010-03-04 09:30:29 EST

*** Bug 304678 has been marked as a duplicate of this bug. ***

Comment 36 Remy Suen 2010-03-11 06:13:14 EST

*** Bug 305468 has been marked as a duplicate of this bug. ***

Comment 37 Francis Upton IV 2010-03-11 10:17:53 EST

I have hit this in HEAD (3.6M6) a couple of times, and also saw it in 3.5.2. I can't reproduce it though, and I think when I go back a couple of pages and then try again it works. In the 3.5.2 case, that did not work, but restarting the install worked.

Comment 38 Susan McCourt 2010-04-25 16:55:58 EDT

(In reply to comment #31)
> Here's what I've just realized.
> If *some other repo* that has these references is in the list of sites, and it
> has *never been loaded* before, and the user has
> 
> [x] Contact all update sites...
> 
> checkmarked, then the problem could still occur, because the planner will
> attempt to load all repositories, and the UI will receive repo addition/removal
> events associated with composite children that indeed could influence this
> case.

With bug 310206 implemented, this kind of thing can happen more often, because now we follow enabled repository references when resolving, so it's more likely than ever that we encounter a previously unseen repository while resolving.  

I've been trying to reproduce this bug today with event tracing on, and when I tried to follow Steve's steps in comment #32, I would occasionally notice that adding the JBoss site would intermittently cause the m2eclipse site to appear in the combo box after the JBoss info was shown in the viewer.  This is an example of the problem where a site refers to another site, and so the first time it is loaded, another site gets added.  In this case, it didn't happen during resolving, it happened sooner.  But the bottom line is that the change in the combo will cause selections to be removed which would disable the wizard finish button if it had been enabled while the repo was being added.

The symptom seems to be timing related, but all the UI listeners are synchronous, so it's been bugging me that this still happens.  I realized today while looking at the traces that the add event was coming after all the batching, and finally realized why.  

Even though all the UI events are synchronous, the repository managers have asynchronous listeners.  They listen for discovery events and post "add" events when a repo reference is discovered.  So the repo manager processes the discovery event asynchronously, after the UI is done loading and batching is off.  It posts the add event and the UI responds...

Since the UI can't really control the window in which these events happen, I've decided to turn off all responding to events while the wizard is open.  This fixed the problem I saw with JBoss and M2Eclipse, and I see in the trace that all discovery is ignored by the UI.  

I'm not going to say (again) that I've definitely fixed this bug, but I've seen event traces that show how it happens and plugged the holes that I found.

If no one observes this during the M7 2-day test pass, I'm going to close it.

Comment 39 Daniel Le Berre 2010-04-26 07:29:01 EDT

I ran into the disabled finish button last week with the IBuild from wednesday when installing subclipse. It was the first time it happened to me.

AFAI remember, the problem occurred when I did select all but two plugins to install.

Then I did it again by selecting all (clicking on the categories instead of individual plugins). It worked.

I was running a Linux x86_64 GTK 2 system at work. I never got that problem at home, where I have a similar hardware and exactly the same OS.

I thought it was a GTK2 related problem (on that machine, I tried a lot of hacks to make Eclipse 3.5.1 to work with GTK 2.28).

Sorry for not being more precise, I was not aware of that bug before the post of Susan on p2 ML.

Comment 40 oouc 2010-04-26 19:35:22 EDT

Ok my bug is considered a duplicate of this one.  But going all the way back or hitting Cancel on the wizard just hangs me up much earlier instead of near Finish.

Build Identifier: Galileo from Ubuntu 9.10 but Eclipse is hung so I can't see
numbers

I can't do Android development in Ubuntu 10.4 so I downgraded to 9.10 and
Eclipse hangs.

Reproducible: Always

Steps to Reproduce:
1.Synaptic installs Eclipse
2.Choose "All Available"
3.http://download.eclipse.org/releases/Galileo
Select Mobile, Web, and other apps that might help with Android development.
Eclipse is hung.  Delete some apps.  Eclipse is still hung.

[reply] [-] Comment 1 oouc@yahoo.com 2010-04-26 15:28:08 EDT

Created an attachment (id=166124) [details]
Screenshot where Eclipse is hung

Click,  Alt-A, or Even click on Help do not work.

[reply] [-] Comment 2 Remy Suen 2010-04-26 15:30:34 EDT

So you mean Eclipse won't respond to your input or that you can't advance to
the next page?

[reply] [-] Comment 3 Susan F. McCourt 2010-04-26 15:41:15 EDT

(In reply to comment #2)
> So you mean Eclipse won't respond to your input or that you can't advance to
> the next page?

If Eclipse seems hung, can you please attach a stack trace?
See http://wiki.eclipse.org/How_to_report_a_deadlock

I've never seen a bug about Eclipse hanging when trying to accept a license,
though I just found this reference in a WST FAQ (are you using WTP?)

http://wiki.eclipse.org/WTP_FAQ#The_license_dialog_hangs_Eclipse_or_doesn.27t_allow_me_to_click_accept._What_can_I_do.3F

If the problem is that you can't advance to the next page or push finish, it
could be bug #277265, but typically the problem is not observed again if you
cancel the wizard and then open it again to do the same steps.



277265 may be a duplicate.  But when I hit cancel.  I cannot get anywhere because I already have GalileoDev and it will not let me delete it or even get a next when I give the url /releases/Galileo.

Comment 41 Susan McCourt 2010-05-17 23:49:31 EDT

I'm going out on a limb and marking this fixed as of 3.6 M7.

I tried all the old scenarios, including the ones in duplicate bugs, without a problem.  But of course I never saw the problem in the first place.  Reading the old descriptions, it definitely sounds as if it happened when the repo was added by typing it into the combo.  I still believe the original theory that this would happen when:
- the repo being added referred to other sites, which would cause the discovery/add events to occur
OR
- [x] Contact all sites was checked, and some other site that had been added would cause these events (for example, the first time Helios is loaded, there are a number of repos discovered and added in a disabled state).
OR
- the repo had an artifact repository reference, but due to Bug 300112, a metadata repo event was being posted.

In all of these cases, it would occur the first time the repo with the reference was read, and it would also depend on the timing of events and wizard page turns whether the end result was the disabled finish button.

In M7, I decided instead to start ignoring all events once the wizard was open, unless the user had confirmed changes in the pref page, or did an explicit add via the combo or dialog.  This means that we are not prone to (over)react to discovery events that might have affected the enablement state.

Since no one has reported this problem in M7 or RC1 testing, I'm going to close it.  If anyone watching this bug would like to try again, please pick up the RC1 build and try it.

Comment 42 Susan McCourt 2010-05-17 23:55:42 EDT

Since many of the duplicate bugs and comments here involved installing subclipse, I took a look at the repo references in 
http://subclipse.tigris.org/update_1.6.x

I see
<references size="4">
<repository url="http://eclipse.svnkit.com/1.3.x/" type="1" options="0"/>
<repository url="http://eclipse.svnkit.com/1.3.x/" type="0" options="0"/>
<repository url="http://subclipse.tigris.org/update_1.6.x" type="0" options="0"/>
<repository url="http://subclipse.tigris.org/update_1.6.x" type="1" options="0"/>
</references>

This is kind of interesting.  The site includes references to itself in a disabled state?

Comment 43 Jake Nelson 2010-05-22 17:45:47 EDT

Bug is not fixed- just ran into it today when installing the Android Developer Tools.

Canceling, then going through again worked fine.

Comment 44 Jake Nelson 2010-05-22 17:52:34 EDT

(In reply to comment #43)
> Bug is not fixed- just ran into it today when installing the Android Developer
> Tools.
> 
> Canceling, then going through again worked fine.

Apologies (also apologies for responding to own comment), misread version numbers. Ran into issue on 3.52, may not exist on newer.

Comment 45 JoJo Mising name 2010-08-31 15:06:05 EDT

Is there a current work around for this bug? Per the Android documentation, it states that 3.5 is suggested for the ADT plugin. Unfortunately I am not able to install the Android Developer Tools because of the finish button not being enabled after the "I agree" radio button is selected. I have tried several times even after exiting Eclipse.

Thank you

Comment 46 Pascal Rapicault 2010-08-31 21:50:18 EDT

Closing the wizard and going again through it can help with this. Another approach that has been known to work is to go back several pages and forward again. Sorry for the annoyance. 
Also if you can I suggest that you take a look at 3.6.

Comment 47 JoJo Mising name 2010-09-01 13:22:05 EDT

Hey I have tried several times by closing it out and even going back. It just didn't work for me. 

Per the Android documentation:

"Caution: There are known issues with the ADT plugin running with Eclipse 3.6. Please stay on 3.5 until further notice."

URL reference: http://developer.android.com/sdk/eclipse-adt.html

The cautioned not to use version 3.6. So my next question is this: Just exactly what are the android developers using? Also per the android documentation they clearly suggest in using the ADT plugin with Eclipse. 

URL reference: http://developer.android.com/sdk/eclipse-adt.html

Thanks!

Comment 48 JoJo Mising name 2010-09-01 15:24:53 EDT

Hey I have tried several times by closing it out and even going back. It just didn't work for me. 

Per the Android documentation:

"Caution: There are known issues with the ADT plugin running with Eclipse 3.6. Please stay on 3.5 until further notice."

URL reference: http://developer.android.com/sdk/eclipse-adt.html

The cautioned not to use version 3.6. So my next question is this: Just exactly what are the android developers using? Also per the android documentation they clearly suggest in using the ADT plugin with Eclipse. 

URL reference: http://developer.android.com/sdk/eclipse-adt.html

Thanks!

Comment 49 JoJo Mising name 2010-09-01 15:25:55 EDT

I re- downloaded and was able to properly install it. Weird but it worked.


Thanks.

Comment 50 Susan McCourt 2010-09-01 15:43:36 EDT

(In reply to comment #49)
> I re- downloaded and was able to properly install it. Weird but it worked.
> 
> 
> Thanks.

sorry for the hassle.  This one has been hard to pin down.

Comment 51 Ian Bull 2010-11-12 15:15:11 EST

*** Bug 326495 has been marked as a duplicate of this bug. ***

Comment 52 varad 2010-11-19 09:05:12 EST

Bug still exists. (Trying to install android dev tools.) However going back two pages and then forward enables the finish button.

Eclipse SDK
Version: 3.5.2
Build id: M20100211-1343

Comment 53 Remy Suen 2010-11-19 09:09:15 EST

(In reply to comment #52)
> Bug still exists. (Trying to install android dev tools.) However going back two
> pages and then forward enables the finish button.
> 
> Eclipse SDK
> Version: 3.5.2
> Build id: M20100211-1343

The changes that were put in was for the 3.6 stream (see the 'Target Milestone' field of this bug, which has been set to 3.6M7). You are on 3.5.x. Assuming the changes fixed the problem, it would not even have affected your build/download of Eclipse.

Comment 54 varad 2010-11-19 09:14:46 EST

(In reply to comment #53)
> (In reply to comment #52)
> > Bug still exists. (Trying to install android dev tools.) However going back two
> > pages and then forward enables the finish button.
> > 
> > Eclipse SDK
> > Version: 3.5.2
> > Build id: M20100211-1343
> 
> The changes that were put in was for the 3.6 stream (see the 'Target Milestone'
> field of this bug, which has been set to 3.6M7). You are on 3.5.x. Assuming the
> changes fixed the problem, it would not even have affected your build/download
> of Eclipse.

Oh.. alright. ADT needs 3.5, so had to download this version. Thanks anyway.

Comment 55 Evert 2011-06-01 02:21:46 EDT

This bug still exists. I've tried it in 3.6.2 and also in 3.7 RC3.

I've tried to reopen this bug, but I can't change the status in Bugzilla.

I'm getting the problem when I try to install "CDO Model Repository" and "Net4j Signalling Platform" from CDO Model Repository Site - http://download.eclipse.org/modeling/emf/cdo/updates/4.0-milestones

It happens when there are more than one license to agree to. 

This bug should be a blocker, because it makes people give up on using Eclipse at the very beginning.

Comment 56 Bryan Hunt 2011-06-01 08:54:45 EDT

Reopened by request

Comment 57 Pascal Rapicault 2011-06-11 15:44:04 EDT

We had a bug in RC3. It has been fixed. Closing again.
Please confirm with an RC4 build and the issue keeps occurring then mention the sites from which you are installing.

Comment 58 john 2011-07-06 07:51:08 EDT

Having same problem :

Eclipse SDK

Version: 3.7.0
Build id: I20110613-1736

Trying to install MercurialEclipse, and cannot proceed past the License window. I have accepted each license, individually, and even scrolled (and READ) each one, but I am never provided the 'Next' button.

Comment 59 JoJo Mising name 2011-07-06 13:23:53 EDT

Just do a fresh install. I was having the same problem. It was driving me crazy. Just un-install it (reboot after) and then re-install it.

Comment 60 Pascal Rapicault 2011-07-06 15:16:24 EDT

I have been installing other stuffs successfully. Could you please post the site you are trying to install from. Also could you please check in the error log if you .ave any error message. Thx/

Comment 61 dphaynes Mising name 2011-08-03 17:04:03 EDT

(In reply to comment #60)
> I have been installing other stuffs successfully. Could you please post the
> site you are trying to install from. Also could you please check in the error
> log if you .ave any error message. Thx/

I got this on brand new download/install of the current Indigo release. I've encountered it previously on a fresh install of 3.6 on both Windows 7 x64 and Ubuntu 10.04. 

The current problem is on a nearly bone stock Linux ubuntu 2.6.38-10-generic #46-Ubuntu SMP Tue Jun 28 15:05:41 UTC 2011 i686 i686 i386 GNU/Linux.

I don't find any error logs - the only log file under ~/eclipse is the install log

dhaynes@ubuntu:~/eclipse/configuration/org.eclipse.update$ cat install.log 

!CONFIGURATION 1308010031800 Mon Jun 13 17:07:11 PDT 2011
!ACTIVITY 1312401407562 Aug 03, 2011 12:56:47.562 file:/home/dhaynes/eclipse/ site-install success

One thing that I tend to do that may or may not be related is that I check the 'Hide updates that are already installed' checkbox.

Another thing that I'm not absolutely certain is the case but I *think* that when the license acceptance dialog was presented, the "I accept..." selection was checked. I think the default is the other way around. I'm not at all certain that was the case - I'd say a 50/50 chance I am mistaken.

The solution was as others have described, I had to use the 'back' button to go all the way out to the initial software selection screen. The second time I tried it I got the 'Finish' button enabled.

It seems like this bug should be re-opened.

Comment 62 Bryan Hunt 2011-08-03 17:07:09 EDT

Re-opening as requested.

Comment 63 dphaynes Mising name 2011-08-13 12:41:01 EDT

(In reply to comment #62)
> Re-opening as requested.

Thanks! It's not a critical one but it is an annoying "out of the box" experience and no doubt frustrating for new users.

I created a brand new VM exactly as I did when I last encountered this and I could not reproduce it, with or without the "hide already installed" check box checked.

Comment 64 Missing name 2011-09-13 17:01:09 EDT

Confirmed on 3.7 (I20110613-1736) under Fedora 15 (using rawhide packages). I am also getting hit by Bug 263436 which makes eclipse pretty much unusable on this platform. Could they be related?

Comment 65 Lawrence Angrave 2012-01-20 00:43:55 EST

This bug is still alive in Eclipse 3.7.1

This week I had 400 undergrads download and install Eclipse 3.7.1 and subclipse plugin on their laptops using the instructions here-
https://wiki.engr.illinois.edu/display/cs125/Eclipse+and+SVN+Instructions

A small number of students ran into this bug. It was repeatable on their systems. These students are running Windows on fairly new hardware (64bit PCs, Windows 7 I believe) and had probably installed JDK6.30 or JRE6.30. Sorry I can't more specific. Regards, Lawrence.

Comment 66 John Arthorne 2012-02-15 09:34:58 EST

*** This bug has been marked as a duplicate of bug 342369 ***