Community
Participate
Working Groups
The new screen capture tool looks great. After playing with it for a bit, I have a couple of nits. * hard to discover the "Capture Rectange" * once selected rectangle is captured, it is scaled to fit which can distort the aspect ratio * default color of red seems a bit odd * default text size of 8 seems small * it would be cool if the toolbar on the left was enabled and if a tool was selected, it automatically turned you to annotate mode * the line weight and type selectors are mostly undiscoverable In general, great work!
Thank you for the report. (In reply to comment #0) > * hard to discover the "Capture Rectange" How about the method of the display of the context menu and capture selected rectangle operation? > * once selected rectangle is captured, it is scaled to fit which can distort the > aspect ratio Foot/zoom has not been reset at capture again. This operation is the same as Mylyn 3.0. Should always reset to Fit ? > * default color of red seems a bit odd A present color is RGB(255, 85, 85), and the same color as Mylyn 3.0. Please change SelectToolAction.java line 192 if you change an initial color. THIS> intgerCustom = rgb2int(255, 85, 85); > * default text size of 8 seems small How about making it to the size of 300%? If it is 8, it becomes 24. Please change SelectToolAction.java line 172 if you change an initial size. FontData fontData = parent.getShell().getFont().getFontData()[0]; INSERT> fontData.setHeight(fontData.getHeight() * 3); stringCustom = fontData.toString(); > * it would be cool if the toolbar on the left was enabled and if a tool was > selected, it automatically turned you to annotate mode It is a good idea. I will improve it. > * the line weight and type selectors are mostly undiscoverable Please change ScreenshotCreationPage.java line 590 and 593 to display two tools. THIS> lineTypeToolbar.setVisible(false); THIS> lineBoldToolbar.setVisible(false);
> (In reply to comment #0) > > * hard to discover the "Capture Rectange" > > How about the method of the display of the context menu and capture selected > rectangle operation? I think it's an advanced operation so it's not a big deal if it is more difficult to find. I wonder if we could display some sort of Apply button in the toolbar in Crop mode that would trigger capturing of the current selection. > > * once selected rectangle is captured, it is scaled to fit which can distort > the > > aspect ratio > > Foot/zoom has not been reset at capture again. > This operation is the same as Mylyn 3.0. > Should always reset to Fit ? Zoom to Fit should always respect the aspect ratio and not zoom in to more than 100%. > > * default text size of 8 seems small > > How about making it to the size of 300%? > If it is 8, it becomes 24. What if we use a larger system font by default, e.g. JFaceResources.TITLE_FONT? > > * it would be cool if the toolbar on the left was enabled and if a tool was > > selected, it automatically turned you to annotate mode > > It is a good idea. I will improve it. Hiroyuki, it would be great if you could attach a patch to this bug (as long as it's smaller than 250 lines so we don't need an IP review). > > * the line weight and type selectors are mostly undiscoverable > > Please change ScreenshotCreationPage.java line 590 and 593 to display two tools. > > THIS> lineTypeToolbar.setVisible(false); > THIS> lineBoldToolbar.setVisible(false); It's intentionally hidden by default. Shawn, see bug 266123 for more background.
Created attachment 136883 [details] capture.patch > > * once selected rectangle is captured, it is scaled to fit which can > distort the aspect ratio FIXED > > * default text size of 8 seems small FIXED, used JFaceResources.HEADER_FONT > > * it would be cool if the toolbar on the left was enabled and if a > > tool was selected, it automatically turned you to annotate mode > It is a good idea. I will improve it. FIXED
Created attachment 136884 [details] SelectToolAction.java When the patch is made, the difference of all lines is made. The modified source is up-loaded.
Created attachment 136895 [details] patch
Created attachment 136897 [details] capture.patch The minor bug is fixed.
Great stuff! I have applied the patch.
*** Bug 210020 has been marked as a duplicate of this bug. ***
*** Bug 234599 has been marked as a duplicate of this bug. ***
*** Bug 221952 has been marked as a duplicate of this bug. ***
