Community
Participate
Working Groups
1) Bad label backgrounds 2) Funny white background while "Discovering connectors" 3) "X" icon for deleting text in search textfield disappears when mouse is hovering over it 4) Bad dialog resize behaviour ... inner list isn't resized vertically so it is cropped :-(
Created attachment 136548 [details] Screenshot for issue 1)
Created attachment 136549 [details] Screenshot for issue 2)
Created attachment 136550 [details] Screenshot for 3)
Created attachment 136551 [details] Screenshot for 4)
> 3) "X" icon for deleting text in search textfield disappears when mouse is > hovering over it I broke that with my patch. Mik, should we replace the icons for clearing search text with the ones used by platform (i.e. the eraser and not the X)?
A few more suggestions for improvement: * Remove the indentation for connector, since categories stand out well due to the dark background. * Move the Learn More Link to the left, it's seems natural to click it after reading the text. * Remove the border around the image in the tooltip and don't fill the background. Contributors can frame their images as needed and it looks odd on some images (e.g. the Trac one). I would also consider limiting the filter to the name and short description of the connector to make it more obvious why something is matching (search for "trac" for instance which also matches JIRA).
Fixed: * dialog resize issues * _maybe_ fixed bad label backgrounds (platform-specific, can someone test on Windows?) * learn more to left * image border * tooltip fill
Created attachment 136605 [details] background fix The background color of the labels on the gradient is still opaque. Any reason why you are not reusing GradientCanvas?
Created attachment 136606 [details] mylyn/context/zip
(In reply to comment #8) > background fix Excellent, thanks for the patch! > The background color of the labels on the gradient is still opaque. Any reason > why you are not reusing GradientCanvas? I wasn't aware of its existence... it's only been around for 21 days!!
Created attachment 136610 [details] tooltip on Linux
Created attachment 136690 [details] "sorry" message has grey background I can confirm that 1) and 4) are now fixed. There is one more background issue when displaying "sorry" message.
Created attachment 136696 [details] tooltip background fix
(In reply to comment #13) > Created an attachment (id=136696) > tooltip background fix Note that you dont have to set the background to null as the GradientToolTip will automatically do this for you. The no background flag seemed to make the background of that composite transparent.
Created attachment 136766 [details] wizard does not use dialog font The page should invoke Dialog.applyDialogFont() after creating controls. Also notice the background of the label, not sure if that is intentional.
Raising priority to critical. Tooltips on Linux still have a black background (see patch).
I have committed the patch (comment 13). Let's open separate bugs to track any remaining nits.
