Community
Participate
Working Groups
Removing all filters and attaching to HeapJniCarTest in HeapProf enabled mode causes JVM crash. This problem was fixed in HEAD under bug 275321 for TPTP 4.6. This defect address back porting bug 275321 to TPTP 4.5.2.1 Milestone 2. Please see bug 275321 for more details.
Created attachment 136321 [details] Patch - 4521 - JVM crash on attach in heapprof enabled mode
Requesting approval to include the following defect in 4.5.2.1 branch, on behalf of Chengrui Deng. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Removing all filters and attaching to an agent in HeapProf enabled mode causes JVM crash (using Sun JVM). Is there a work-around? If so, why do you believe the work-around is insufficient? No. Is this a regression or API breakage? Explain. Yes, this functionality worked previously. Does this require new API? No. Who performed the code review? Myself, as Chengrui produced the patch. Is there a test case attached to the bugzilla record? No. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Fix is a simple one-line 'is null' check to one of the heap prof classes. See original bug for details. Risk is low. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.
PMC, Yunan has requested to have bug 275321 backported to TPTP 4.5.2.1. We are now seeking PMC's approval to check this into TPTP 4.5.2.1 Milestone 2.
PMC approved assuming the scenario is covered by an existing test case. Jonathan, please confirm.
patch looks good. this bug is a regression to users and should be fixed.
Indeed you are correct, Paul. Patched checked into HEAD w/ PMC approval.
(In reply to comment #4) > PMC approved assuming the scenario is covered by an existing test case. > Jonathan, please confirm. > Re-submitting my approval.
Created attachment 136489 [details] Patch for updating copyright year to 2009 A few of the files need copyright years updated to 2009. Here's a patch with the changes. I'm checking it into the TPTP-4_5_2_1 branch.
Verified on M2.
