Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 276906 - [build path] Dialog telling about output folder deletion should be improved
Summary: [build path] Dialog telling about output folder deletion should be improved
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-19 10:23 EDT by Pawel Pogorzelski CLA
Modified: 2010-03-09 15:14 EST (History)
2 users (show)

See Also:

Attachments
fix (2.30 KB, patch)
2010-02-23 00:38 EST, Deepak Azad CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2009-05-19 10:23:02 EDT 
Build id: I20090515-1143

Steps:
1. Create a linked folder "bin_ext" in your workspace
2. Change Default output folder to "bin_ext"
4. You have a prompt whether to remove the old location
5. Click Yes and "bin" is deleted
6. Change Default output folder back to "bin"
7. You have a prompt whether to remove the old location

Actual:
8A. Click Yes and "bin_ext" is not deleted

Expected:
8B. Click Yes and "bin_ext" is deleted, it's clear from the prompt:
"The output folder has changed. Do you want to remove the old location "<ROOT/>/bin_ext" and its content?"
Comment 1 Dani Megert CLA 2009-05-20 03:25:17 EDT 
We should improve the message here.

The idea is that we only delete the folder if it has been created and owned by JDT Core (i.e. is marked as derived). We never remove a folder that the user manually created, whether it is a normal or a linked folder.
Comment 2 Deepak Azad CLA 2010-02-23 00:38:35 EST 
Created attachment 159888 [details]
fix
Comment 3 Dani Megert CLA 2010-02-23 08:48:51 EST 
Thanks for the patch.

Committed to HEAD.
Available in builds >= N20100223-2000.
Comment 4 Dani Megert CLA 2010-02-23 08:50:02 EST 
.
Comment 5 Markus Keller CLA 2010-03-09 15:14:07 EST 
Verified in I20100309-0100.