Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 276886 - [publisher] Strange entry on Available Software Sites pref page
Summary: [publisher] Strange entry on Available Software Sites pref page
Status: RESOLVED INVALID
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-19 09:25 EDT by Tomasz Zarna CLA
Modified: 2009-05-19 16:18 EDT (History)
2 users (show)

See Also:


Attachments
Available Software Site pref page (15.04 KB, image/png)
2009-05-19 09:32 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2009-05-19 09:25:15 EDT
3.5RC1

I tried to add JDT Optional Plug-ins with p2[1]. To verify if the site I entered is valid I navigated to Available Software Sites pref page using the link on the Install wizard. The JDT extras site was there so I clicked "Test Connection". The test went fine. Then I closed the pref page and opened it again. A new entry appeared, please take a look at the following screen shot.

[1] bug 276884
Comment 1 Tomasz Zarna CLA 2009-05-19 09:32:22 EDT
Created attachment 136300 [details]
Available Software Site pref page
Comment 2 Tomasz Zarna CLA 2009-05-19 09:35:25 EDT
On JDT UI[1] site there is an info about two update sites:

1. http://www.eclipse.org/jdt/ui/update-site
2. http://www.eclipse.org/jdt/ui/astview/index.php

The strange entry looks like it has something to do with the AST view site (2.) but I didn't add it, at least in a way I'm aware of :)

[1] http://www.eclipse.org/jdt/ui/index.php#optional
Comment 3 Tomasz Zarna CLA 2009-05-19 09:56:55 EDT
(In reply to comment #2)
> On JDT UI[1] site there is an info about two update sites:

Well, this is not true. There is only one update site -> http://www.eclipse.org/jdt/ui/update-site. But still, each time I add it the second one appears out of nowhere.
Comment 4 Susan McCourt CLA 2009-05-19 13:08:20 EDT
There are a number of ways a site can get added to the pref page as a disabled site.  It can be referred to by another repository, or as the update site for a newly installed feature, etc.  So it's not completely surprising that a site can appear in this list without you knowing about it.

That said, I don't see any references in the http://www.eclipse.org/jdt/ui/update-site/site.xml that would explain why this reference is added.

Ian, I set a breakpoint in LocalMetadataRepository.publishRepositoryReferences() and sure enough, there are 4 references being published after the update site is parsed.  Two references are to the original site URI (?) and two are to this URI:

http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/jdt-ui-home/plugins/org.eclipse.jdt.astview/AST-View-Site/

Can you explain what is happening here?  Is this a bug?


Comment 5 Ian Bull CLA 2009-05-19 13:50:47 EDT
It seems a little strange.  I'm pretty sure we are not adding random URLs to the list of known repositories, but stranger things have happened.  I wonder if one of the features specify an Update URL?  I will see if I can track down where this is coming from.
Comment 6 Ian Bull CLA 2009-05-19 13:57:45 EDT
Yep, it appears:
Feature org.eclipse.jdt.astview.feature version: 1.0.1

has specified an UpdateSite URL as:
http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/jdt-ui-home/plugins/org.eclipse.jdt.astview/AST-View-Site/

We see this when publishing the site.xml, and add it to the known list of repos.
Comment 7 Susan McCourt CLA 2009-05-19 16:18:30 EDT
thanks, Ian.
For some reason, I thought I had to actually install a feature to get its update site added as a repo ref.  I didn't realize it happened when I add the site that contains it, but I can understand why (since we are already parsing everything).

So I think we can mark this as INVALID as there is no bug here.