Community
Participate
Working Groups
This is a very simple patch to enable Mac OSX build of CommonBaseEvent native code which is needed to build AgentController. I'm Submitting a patch and two files to go with it. The patch adds a macro for detecting Darwin settings in the makefile. And it takes out reference to the nonstandard malloc.h . stdlib.h is the standard platform independent way of accessing the malloc functions (also there seem to be no reference to memory routines in that file).
Created attachment 136119 [details] build fix for darwin
Created attachment 136120 [details] makefile fragment include.darwin needs to go in src.native/CommonBaseEvent directory
Created attachment 136121 [details] unittesting shell script This file goes in the src.native/CommonBaseEvent/UnitTest/scripts folder. The way you invoke is UnitTest/scripts/UT_CBE_Darwin.sh -l packaging -a ut
Clarification, this is small patch by itself is enough to get CBE built and unittested sucessfully on Mac OSX intel. It was posted on #68111 by Pierre and updated by Scott.
Thank you for contributing these patches. It's great to have the community contribute to the porting of the AC on Mac OS. We'll take a look at the patch and get back to you. Could you please clarify on what kinds of scenarios you were able to do on MAC OS with all these patches? May be you could open a top level bugzilla on porting the AC to MAC and we could continue our general discussion there? These bugs can then be a dependency for that top level bugzilla.
Thanks! Paul, please take a look at merging these MAC OS patches to the current code base in HEAD for post TPTP 4.6.
Patch is good! Also, just an FYI that there is some legal stuff that needs to be completed before the patches are checked in. Kathy can provide you with the appropriate details.
Hi Spundun, Could you please add a comment to this bugzilla to confirm that you authored 100% of the content submitted in this patch and you have the rights to donate the content to Eclipse under the EPL (http://eclipse.org/legal/epl-v10.html)? Note that the answer to the above question is part of the requirement for getting legal approval for checking in your contributions to CVS.
-> I Authorize all the work that I've done, to be used under EPL, by the project that this bugzilla currently belongs to. -> It should be noted that some of the contribution has come under my time at work with my employer "University of Southern California, Information Sciences Institute". The official url is www.isi.edu . -> Please understand that my efforts were mostly spent in re-organizing existing patches and code. This code was already contributed to bug #68111 by other folks. I *did* contribute improvements to the existing patch, in terms of better organization, readability, and overall compatibility with current CVS head.
Also I have gotten the approval of my employer for this contribution
Please add the following to the header of all files contributed by Spundun: Contributed by Spundun Bhatt (spundun@gmail.com), with the support and encouragement of the University of Southern California Information Sciences Institute Distributed Scalable Systems Division.
Note that the CQ for Spundun's contribution to RFE bug 68111 (and it's child defects bug 276591 bug 276607, bug 276615 and bug 276640) have been approved by the Eclipse IPO under CQ 3397 (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3397). The patch can be checked in now with the above update to the header of all files contributed by Spundun.
Patch checked into HEAD. Thanks Spundun!
Updating status.
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
