Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 276607 - MAC OS: Fixes compiler errors on mac, using TID typedef instead of hardcoded native win32/linux types.
Summary: MAC OS: Fixes compiler errors on mac, using TID typedef instead of hardcoded ...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Paul Klicnik CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: closed471
Keywords:
Depends on:
Blocks: 68111
  Show dependency tree
 
Reported: 2009-05-16 22:56 EDT by Spundun Bhatt CLA
Modified: 2016-05-05 10:59 EDT (History)
1 user (show)

See Also:


Attachments
replace DWORD & unsigned int tids with type TID (6.16 KB, patch)
2009-05-16 22:57 EDT, Spundun Bhatt CLA
no flags Details | Diff
updated patch (6.81 KB, patch)
2009-05-17 01:40 EDT, Spundun Bhatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Spundun Bhatt CLA 2009-05-16 22:56:05 EDT
Here is another simple patch that is needed for mac osx build. It also cleans up some of the solaris flags with the correct fix.
Comment 1 Spundun Bhatt CLA 2009-05-16 22:57:31 EDT
Created attachment 136109 [details]
replace DWORD & unsigned int tids with type TID
Comment 2 Spundun Bhatt CLA 2009-05-17 01:40:22 EDT
Created attachment 136115 [details]
updated patch

one occurance slipped through the cracks last time. + updated paths
Comment 3 Kathy Chan CLA 2009-05-22 10:10:19 EDT
Thank you for contributing these patches.  It's great to have the community contribute to the porting of the AC on Mac OS. We'll take a look at the patch and get back to you.  

Could you please clarify on what kinds of scenarios you were able to do on MAC OS with all these patches?  May be you could open a top level bugzilla on porting the AC to MAC and we could continue our general discussion there?  These bugs can then be a dependency for that top level bugzilla.
Comment 4 Kathy Chan CLA 2009-05-25 17:02:00 EDT
Thanks!

Paul, please take a look at merging these MAC OS patches to the current code base in HEAD for post TPTP 4.6.
Comment 5 Jonathan West CLA 2009-05-26 15:31:55 EDT
Patch looks good, once the 4.6.1 stream is open I will check in.
Comment 6 Spundun Bhatt CLA 2009-06-02 03:54:48 EDT
Can you tell me where I can keep track of when the stream will be opened? Is there a roadmap page or mailing list thread where this discussion takes place?
Comment 7 Jonathan West CLA 2009-06-07 19:56:11 EDT
Discussions take place on the TPTP-PMC mailing list:
http://dev.eclipse.org/mailman/listinfo/tptp-pmc

The release schedule is available, by version, from:
http://www.eclipse.org/tptp/home/project_info/index.php
Comment 8 Kathy Chan CLA 2009-06-29 10:45:54 EDT
Comment on attachment 136109 [details]
replace DWORD & unsigned int tids with type TID

Patch updated in https://bugs.eclipse.org/bugs/attachment.cgi?id=136115
Comment 9 Kathy Chan CLA 2009-07-13 15:07:45 EDT
Hi Spundun,

Could you please add a comment to this bugzilla to confirm that you authored 100% of the content submitted in this patch and you have the rights to donate the content to Eclipse under the EPL (http://eclipse.org/legal/epl-v10.html)? Note that the answer to the above question is part of the requirement for getting legal approval for checking in your contributions to CVS.
Comment 10 Spundun Bhatt CLA 2009-07-21 19:51:45 EDT
-> I Authorize all the work that I've done, to be used under EPL, by the project that this bugzilla currently belongs to.

-> It should be noted that some of the contribution has come under my time at work with my employer "University of Southern California, Information Sciences Institute". The official url is www.isi.edu . *And I have gotten the approval of my employer for this contribution*

-> Please understand that my efforts were mostly spent in re-organizing existing patches and code. This code was already contributed to bug #68111 by other folks. I *did* contribute improvements to the existing patch, in terms of better organization, readability, and overall compatibility with current CVS head.
Comment 11 Kathy Chan CLA 2009-07-28 14:26:07 EDT
Please add the following to the header of all files contributed by Spundun:

Contributed by Spundun Bhatt (spundun@gmail.com), with the support and encouragement of the University of Southern California Information Sciences Institute Distributed Scalable Systems Division.
Comment 12 Kathy Chan CLA 2009-07-29 12:34:03 EDT
Note that the CQ for Spundun's contribution to RFE bug 68111 (and it's child defects bug 276591 bug 276607, bug 276615 and bug 276640) have been approved by the Eclipse IPO under CQ 3397 (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3397).  The patch can be checked in now with the above update to the header of all files contributed by Spundun.
Comment 13 Jonathan West CLA 2009-08-06 21:35:41 EDT
Patch checked into HEAD. Thanks Spundun!
Comment 14 Kathy Chan CLA 2010-11-18 18:48:24 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.