Community
Participate
Working Groups
3.5 RC1 See bug 117340 for background info, except that this bug is for Cocoa (bug 117340 is for Carbon). With Cocoa, however, we have a better chance of fixing this to work the way it works on other SWT platforms: i.e. use TAB, SHIFT+TAB, CTRL+TAB, and CTRL+SHIFT+TAB to navigate to a toolbar, and then use arrow keys to navigate within a toolbar.
Created attachment 136073 [details] partially working patch Here is a patch that was hacked up by SSQ right before 3.5 RC1. Note that this patch only partially works. Problems are: - SHIFT+TAB and CTRL+SHIFT+TAB still need to be made to work - After cycling through all of the controls with TAB or CTRL+TAB, the second time through the controls only gives focus to every 2nd toolbar - if all of the items in a toolbar are disabled, the toolbar is given focus anyhow (but none of the items will have the glowing focus ring because they are all disabled) (other platforms skip entirely-disabled toolbars during traversal). However, note that this patch does allow keyboard navigation through toolbars. It just needs a bit more work. We should do this for 3.6.
Any plans to release this for 3.6?
I'm starting up SWT work again as of tomorrow, but with EclipseCon I probably won't look at this right away. But yes, I think we should be able to do this for 3.6.
Changed the name to reflect what this bug wants fixed. This bug is tracking the fact that traversal via the tab key is broken in toolbars. There is an additional problem in that toolbars aren't seen in the accessibility hierarchy, so VoiceOver doesn't work, so they aren't 'accessible' in that sense. Tracked in bug 307947.
The patch here is mostly correct except for when we attempt to restore focus to the ToolItem that last had focus. When we get a FocusOut event the first responder has already been changed, so when we try to save the focussed item we're actually tracking a ToolItem in the ToolBar we are moving to, not the one in the toolbar that had the focus. Fix is to track the focused ToolItem when we change it or remove it and don't worry about focus events.
Created attachment 163749 [details] Final patch Final patch
Fixed > 20100402.
Created attachment 163819 [details] Additional patch This patch is also needed to prevent multiple keyDowns from being generated on some controls.
*** Bug 275957 has been marked as a duplicate of this bug. ***
