Community
Participate
Working Groups
Created attachment 136036 [details] Proposed patch When using multiple logins with the same username, messages are sent to the user which logged in last, instead of the specific username/resourceID that was specified. In the class org.eclipse.ecf.internal.provider.xmpp.smack.ECFConnection, the method #sendMessage(ID, Message) determines the receiver for the XMPP message based on the IDs getUsernameAtHost(), which does not include the XMPP resource ID. If rcvr.getFQName() is used instead, the problem disappears.
Setting target milestone to RC2 and adding Remy, Marcelo for review of proposed fix/patch. Thanks Jorg for finding/reporting and the proposed patch.
Looks fine to me, thanks for the patch, Jorg. In the future, please create a patch and set the 'Patch Root' to be at the 'Workspace' level. This translates to less mouse clicks when applying patches because Eclipse will already know which project(s) to patch.
+1 from me for the patch. Thanks Jorg. After Marcelo's assent Remy would you like to apply and release? (if you would rather, I will...doesn't matter to me). Thanks.
(In reply to comment #3) > After Marcelo's assent Remy would you like to apply and release? (if you would > rather, I will...doesn't matter to me). Thanks. I don't mind but if you want this in as fast as possible then it would be easier if Marcelo pushes it in if he is okay with the diff. Saves the round trip of either of us reading the email and committing it.
(In reply to comment #4) > (In reply to comment #3) > > After Marcelo's assent Remy would you like to apply and release? (if you would > > rather, I will...doesn't matter to me). Thanks. > > I don't mind but if you want this in as fast as possible then it would be > easier if Marcelo pushes it in if he is okay with the diff. Saves the round > trip of either of us reading the email and committing it. > Ok...sounds good to me. Marcelo please approve, apply and release to head after you've had a chance to examine and test. If you aren't able to do it for time or another reason just reassign and one of us will Thanks all.
The patch is working fine and fix the bug. The code is already on the HEAD. Thanks Jörg!
iplog was changed and the fix in is place.
