Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 276324 - [ViewMgmt] CycleBaseHandler throws NPE if no workbench parts available
Summary: [ViewMgmt] CycleBaseHandler throws NPE if no workbench parts available
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Oleg Besedin CLA
QA Contact: Boris Bokowski CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-14 11:03 EDT by Remy Suen CLA
Modified: 2009-09-15 10:38 EDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (2.65 KB, text/plain)
2009-08-06 06:24 EDT, Dina Sayed CLA 		ob1.eclipse: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2009-05-14 11:03:58 EDT 
Build id: I20090512-2000

1. Check that Ctrl+F8 shows at least two perspectives. If not, switch to another perspective and then try again. As it should remember your previous one, you should now have two choices.
2. Close all the views and editors in your perspective so you have no workbench parts.
3. Try Ctrl+F8 again.
4. Nothing happens. An NPE is logged.

java.lang.NullPointerException
	at org.eclipse.ui.internal.CycleBaseHandler.openDialog(CycleBaseHandler.java:132)
	at org.eclipse.ui.internal.CycleBaseHandler.execute(CycleBaseHandler.java:118)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:294)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
Comment 1 Dina Sayed CLA 2009-08-06 06:24:10 EDT 
Created attachment 143629 [details]
Proposed patch
Comment 2 Oleg Besedin CLA 2009-08-07 10:54:20 EDT 
Good fix, I'll apply it to the Head once 3.6M1 is declared. Thank you Dina!
Comment 3 Oleg Besedin CLA 2009-08-10 15:19:09 EDT 
Patch applied to CVS Head. Thank you!
Comment 4 Remy Suen CLA 2009-08-15 10:00:15 EDT 
Dina, I noticed you are not CC'd on this bug, fyi, Oleg has released your patch to CVS HEAD, thanks for your contribution!

We currently have no assignee for this fixed bug (which I believe goes against our triage/bug management rules). Oleg, do you want to take this to ensure that it gets verified during our M2 verification pass?
Comment 5 Boris Bokowski CLA 2009-08-17 08:35:38 EDT 
reopening so that I can reassign
Comment 6 Boris Bokowski CLA 2009-08-17 08:36:24 EDT 
marking fixed again
Comment 7 Oleg Besedin CLA 2009-09-15 10:38:07 EDT 
Verified in I20090915-0100.