Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 276232 - Connector Discovery wizard changes
Summary: Connector Discovery wizard changes
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 276940 276942
Blocks: 272621
  Show dependency tree
 
Reported: 2009-05-13 23:15 EDT by David Green CLA
Modified: 2009-06-09 17:18 EDT (History)
1 user (show)

See Also:


Attachments
reuse SelectionProviderAdapter (4.79 KB, patch)
2009-05-14 03:06 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (1.23 KB, application/octet-stream)
2009-05-14 03:06 EDT, Steffen Pingel CLA
no flags Details
mylyn/context/zip (41.63 KB, application/octet-stream)
2009-05-14 11:42 EDT, David Green CLA
no flags Details
updated layout for tooltip (113.55 KB, image/png)
2009-05-15 11:56 EDT, David Green CLA
no flags Details
mylyn/context/zip (10.54 KB, application/octet-stream)
2009-05-19 12:16 EDT, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2009-05-13 23:15:45 EDT
* Only show tooltip when hovering over additional question mark icon
* Use gradient for background of tooltip
* Change layout of tooltip to text left, image right: size 640x240+ padding
* Add Learn More link on the bottom right corner of the tooltip
* Remove More Information link to table
* Use gradient to distinguish categories in table (polish)
* Limit length of description  (polish)
* Connector list flickers when categories are toggled, consider hiding instead of re-creating controls
* Blank space at the end of the connectors list
* Keyboard navigation doesn't work on Mac
* Ensure focus control is always visible in connector list
* Hide installed features
* Add context sensitive help
* Make wizard taller
* Add "Find" label to search, move search box on same line as category check boxes
* Categories: Tasks, Documents, Version Control
* Detailed description for categories should be in tooltip
Comment 1 Steffen Pingel CLA 2009-05-13 23:51:01 EDT
WorkbenchUtil.openUrl() is now available if you want to use it for opening web pages.
Comment 2 Steffen Pingel CLA 2009-05-14 03:06:02 EDT
Created attachment 135745 [details]
reuse SelectionProviderAdapter

I have committed the attached patch to improve code reuse.
Comment 3 Steffen Pingel CLA 2009-05-14 03:06:03 EDT
Created attachment 135746 [details]
mylyn/context/zip
Comment 4 David Green CLA 2009-05-14 11:42:23 EDT
tooltip behaviour changed, now requires click on question icon to activate
Comment 5 David Green CLA 2009-05-14 11:42:31 EDT
Created attachment 135801 [details]
mylyn/context/zip
Comment 6 David Green CLA 2009-05-15 11:56:14 EDT
Created attachment 136022 [details]
updated layout for tooltip
Comment 7 Steffen Pingel CLA 2009-05-17 03:57:33 EDT
The new tooltips look great!

David, I have committed a new viewer to commons.ui that is used by the integrated bug reporting and has some similarities with the discovery wizard (screenshots are on bug 212209). The implementation is based on a StructuredViewer which provides filtering and sorting for free but still uses custom controls for the list items. It is intended to be generic but I don't know if it fits your use-case well. You can take a look at ControlListViewer and ControlListItem if you are interested. Feel free to take make any changes required to generalize the implementation. Note that I haven't tested the classes much other than making them work for the support wizard (Help > Report Bug of Enhancement).  
Comment 8 Steffen Pingel CLA 2009-05-17 05:06:52 EDT
We should consider capturing the Esc key when the tooltip is visible in the wizard. It has happened multiple times that I want to close the tooltip but ended up closing the wizard instead. 
Comment 9 David Green CLA 2009-05-19 12:16:43 EDT
Current status:

* -Only show tooltip when hovering over additional question mark icon- click instead of hover to make it consistent with other help icons
* Use gradient for background of tooltip
* -Change layout of tooltip to text left, image right: size 640x240+ padding-
* -Add Learn More link on the bottom right corner of the tooltip-
* -Remove More Information link to table-
* -Use gradient to distinguish categories in table (polish)-
* -Limit length of description  (polish)-
* -Connector list flickers when categories are toggled, consider hiding instead of recreating controls- redraw is now controlled: please retest on your platform
* -Blank space at the end of the connectors list-
* Keyboard navigation doesn't work on Mac
* Ensure focus control is always visible in connector list
* -Hide installed features-
* Add context sensitive help
* -Make wizard taller-
* -Add "Find" label to search, move search box on same line as category check boxes-
* -Categories: Tasks, Documents, Version Control-
* -Detailed description for categories should be in tooltip-
* -capture Esc key when tooltip is shown-

remaining issues created as subtasks.
Comment 10 David Green CLA 2009-05-19 12:16:46 EDT
Created attachment 136329 [details]
mylyn/context/zip
Comment 11 David Green CLA 2009-05-19 18:45:16 EDT
(In reply to comment #7)
> David, I have committed a new viewer to commons.ui that is used by the
> integrated bug reporting and has some similarities with the discovery wizard
> (screenshots are on bug 212209).

Thanks Steffen it looks good.  We should look at integrating this when it won't introduce risk into the project.  Currently we're working to a deadline so I'd prefer to focus on that.
BTW, I noticed that ControlListItem has some mac-specific code keyed on comparing the platform to "carbon".  You may want to make that work for Cocoa also.
Comment 12 Steffen Pingel CLA 2009-05-19 19:16:26 EDT
> BTW, I noticed that ControlListItem has some mac-specific code keyed on
> comparing the platform to "carbon".  You may want to make that work for Cocoa
> also.

Good point. I copied that bit from platform. We should definitely review that code before moving it to a non-internal package.

I agree that we should consider the integration after release when we have more time.