Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 275623 - The Parameter "caption" in the UIControlsFactory should be renamed to "text"
Summary: The Parameter "caption" in the UIControlsFactory should be renamed to "text"
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1.0.RC1   Edit
Assignee: Elias Volanakis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 05:21 EDT by Sabine Achilles CLA
Modified: 2009-11-18 11:53 EST (History)
2 users (show)

See Also:


Attachments
Renaming "caption" to "text" (3.54 KB, patch)
2009-05-11 05:48 EDT, Sabine Achilles CLA
christian.campo: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Achilles CLA 2009-05-11 05:21:05 EDT
Parameters that are used to call the setText(String text) Method of a control should be renamed to "text". Not only is this more fitting, but also the SWT Designer has Problems if this parameter is named differently. Naming the parameter any other than "text" results in the Designer not recognizing this parameter as a text property and separately calling the setText(String text) method on a control in the view instead of changing the parameter in the method call of the factory.
Comment 1 Sabine Achilles CLA 2009-05-11 05:48:38 EDT
Created attachment 135120 [details]
Renaming "caption" to "text"
Comment 2 Elias Volanakis CLA 2009-05-11 16:23:52 EDT
From the technical standpoint: patch looks good and could go into RC1.

Christian, Sabine - please confer about legal side of things. My guess is that the short route Figure 2 > Figure 7 > Figure 8 is applicable?

http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
Comment 3 Christian Campo CLA 2009-05-11 16:39:16 EDT
+1 checkit in....
Comment 4 Elias Volanakis CLA 2009-05-11 17:15:48 EDT
Thanks for the patch!

Applied in HEAD > 20090511.