Community
Participate
Working Groups
1. The New Fortran project wizard is currently accessible via File > New > Project..., but it should be more easily accessible as (a) File > New > Fortran Project (b) Right-click in the Fortran Projects view > New > Fortran Project (c) It should have an icon in the dropdown menu for the "New" toolbar button 2. Similarly, if you click File > New > Other..., there is a Fortran Source File wizard and a Fortran Source Folder wizard. These should be accessible in the same places. If possible, these can replace the current "New Source File" and "New Source Folder" items in the menu, which create C/C++ source files and folders. This can be limited to the Fortran perspective, if necessary.
3. If you place the cursor immediately after the last character of an identifier (which is followed by a whitespace or other non-alphanumeric character) and then choose Refactor > Rename, the intent is to rename the preceding identifier. However, currently, the cursor must be placed inside or before the identifier. This can probably be fixed by adding a second test inside the loop in FortranRefactoring#findEnclosingToken 4. It should be possible to apply the Introduce Implicit None refactoring to every Fortran file in a project or source folder by right-clicking the project or folder in the Fortran Projects view and clicking on a Refactor > Introduce Implicit None item in the context menu. (Eventually we should generalize this behavior to other refactorings that don't require any user input.)
Regarding #1 and #2, if you right-click on the toolbar in Photran, click on "Customize Perspective," switch to the Commands tab, uncheck the C/C++ actions, and check the various Fortran actions, you get the desired results. So, basically, I think you want to achieve the same thing programmatically.
It looks like #4 will contain most of what we need to cover #271519 as well https://bugs.eclipse.org/bugs/show_bug.cgi?id=271519
Created attachment 137522 [details] Patch fixes bugs 3 and 4 on the list
Created attachment 137571 [details] Re-structures some base RefactoringAction and Refactoring classes to provide support for refactoring mutliple files
Hi Tim, I just noticed a couple quick changes to the new patch... (1) Please replace the AbstractFortranEditor class with the one that's currently in HEAD. I committed a fix yesterday that takes care of the problem you were having, so AbstractFortranEditor#getIFile should not need to be changed. (2) The JavaDoc comments for the SingleFileFortranRefactoring and MultipleFileFortranRefactoring classes currently just has "@author tyuvash2" -- please put in a brief description for the class and change the @author tag to include our full names (this is important for the IP process). Thanks. Jeff
Created attachment 137701 [details] Replaced previous patch.
Patch looks good; thanks, Tim. Waiting on reply from Legal...
Hi Tim, Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? For #1, if you borrowed code from either Photran or CDT, that is fine, as long as you state that explicitly. Thanks. Jeff
Jeff, 1. Yes 2. Yes 3. Yes
This is entered as CQ3400 and is waiting on approval. http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3400
CQ approved; committed to CVS.
