Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 275447 - [javadoc] IFileBufferManager should specify that null is OK for progress monitors
Summary: [javadoc] IFileBufferManager should specify that null is OK for progress moni...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-08 08:01 EDT by Markus Keller CLA
Modified: 2009-05-15 05:16 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-05-08 08:01:22 EDT 
I20090507-2000

Many callers of IFileBufferManager#connect(IPath, LocationKind, IProgressMonitor) pass null for the monitor, but this is not documented.

Should make a pass over implementations of all IFileBufferManager methods that take a monitor, and if they can all deal with null, mention this in the Javadocs.
Comment 1 Dani Megert CLA 2009-05-08 08:30:55 EDT 
Also fixed IFileBuffer and GenericFileBufferOperationRunner.
Comment 2 Dani Megert CLA 2009-05-15 05:16:40 EDT 
Verified whole file buffers plug-in in I20090514-2000.