Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 275369 - [publisher] NPE when no executable feature specified on the ProductPublisher Application
Summary: [publisher] NPE when no executable feature specified on the ProductPublisher ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-07 16:05 EDT by Ian Bull CLA
Modified: 2009-05-08 20:47 EDT (History)
2 users (show)

See Also:
pascal: review+
john.arthorne: review+

Attachments
Checks for null before creating a new File object (1.24 KB, patch)
2009-05-07 22:57 EDT, Ian Bull CLA 		pascal: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2009-05-07 16:05:28 EDT 
When the product publisher application is called without an executable feature an NPE is thrown.
Comment 1 Ian Bull CLA 2009-05-07 22:32:54 EDT 
I'm targeting 3.5 with this bug for two reasons:
1. NPEs are never good.  We create a File (new File(..)) with a null location, and this can easily be avoided (i.e. high value)
2. The publisher actually supports the absence of the Executable feature, this bug (and the fix) is entirely contained in the ProductPublisherApplication (i.e. low risk)
Comment 2 Ian Bull CLA 2009-05-07 22:57:32 EDT 
Created attachment 134912 [details]
Checks for null before creating a new File object

This patch checks for null before creating a file.
Comment 3 John Arthorne CLA 2009-05-08 11:41:03 EDT 
Fix looks good.
Comment 4 Pascal Rapicault CLA 2009-05-08 20:47:33 EDT 
Patch released in HEAD.