275240 – Externalize strings wizard fails to detect strings that need externalizing

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 275240 - Externalize strings wizard fails to detect strings that need externalizing

Summary: Externalize strings wizard fails to detect strings that need externalizing

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.5
Hardware:	Macintosh Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	3.5 RC1
Assignee:	Chris Aniszczyk
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-05-06 20:38 EDT by David Green
Modified:	2009-05-07 15:33 EDT (History)
CC List:	3 users (show)

See Also:

Flags:	darin.eclipse: review+

Attachments
the plug-in project that cannot have strings externalized (2.90 KB, application/octet-stream) 2009-05-06 20:39 EDT, David Green	no flags	Details
patch that avoids NPE (1.64 KB, patch) 2009-05-07 12:39 EDT, David Green	caniszczyk: iplog+	Details \| Diff
mylyn/context/zip (972 bytes, application/octet-stream) 2009-05-07 14:41 EDT, Chris Aniszczyk	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Green

2009-05-06 20:38:09 EDT

Steps to reproduce:

# go to the Java perspective
# using the PDE wizard, create a new plug-in project
# Proceed through the wizrad and uncheck 'Generate Activator', 'Contributes to UI' and 'Use a template' options
# press 'Finish'
# press 'no' when it asks to switch to the plug-in perspective
# Right-click on the new plug-in project in the Package Explorer view, select 'PDE Tools -> Externalize Strings' from the context menu
# Observe that the new plug-in project does not appear in the wizard, despite the fact that it has externalizable strings in the MANIFEST.MF

Problem discovered using Version: 3.5.0 Build id: I20090505-2000

Comment 1 David Green

2009-05-06 20:39:03 EDT

Created attachment 134718 [details]
the plug-in project that cannot have strings externalized

Comment 2 David Green

2009-05-06 20:40:09 EDT

Using Eclipse 3.4.2 the Externalize Strings wizard works fine on the same project (even though the project was created in Eclipse 3.5)

Comment 3 Darin Wright

2009-05-07 09:40:46 EDT

Using  I20090505-2000, this works for me. There is one string to externalize - the name of the bundle.

Comment 4 Chris Aniszczyk

2009-05-07 10:40:32 EDT

This works for me also.

Comment 5 Darin Wright

2009-05-07 10:49:28 EDT

tagging as such

Comment 6 David Green

2009-05-07 12:38:28 EDT

Works for me when in a newly-created workspace.   
This problem seems to be specific to a workspace.

Comment 7 David Green

2009-05-07 12:39:44 EDT

Created attachment 134813 [details]
patch that avoids NPE

the problem occurs when an exsd schema element is not found.  Attached a patch that avoids the NPE that was causing the wizard to fail.

Comment 8 Chris Aniszczyk

2009-05-07 14:41:07 EDT

done.

> 20090507

Thanks for the persistence and the patch David.

Comment 9 Chris Aniszczyk

2009-05-07 14:41:12 EDT

Created attachment 134829 [details]
mylyn/context/zip

Comment 10 Darin Wright

2009-05-07 14:48:52 EDT

Verified.

Comment 11 David Green

2009-05-07 15:33:17 EDT

Thanks for the quick response!  I love the PDE tools btw.