Community
Participate
Working Groups
The discovery plug-ins are only supported on 3.5 and currently do not compile on 3.4 but are expected to be distributed on 3.4 and 3.5. Proposed approach: * Branch plug-ins for Eclipse 3.4, potentially removing all code to avoid any maintenance in the future * The AllDiscoveryTests suite will be empty for 3.4 and no contributions will be made by the plug-ins * Update releng scripts to copy discovery plug-in bits from 3.5 build
David, dependencies on P2 plug-ins that are not available on 3.4 should be optional to support installation into 3.4.
If we're branching the discovery plug-ins, how about we remove their dependencies altogether. It would make development of 3.5 branch (head?) easier.
(In reply to comment #2) > If we're branching the discovery plug-ins, how about we remove their > dependencies altogether. It would make development of 3.5 branch (head?) > easier. Ignore that last comment... I wasn't thinking.
I'll resolve this tomorrow after Shawn and I have looked through the code.
Added plug-ins to the Mylyn feature. I moved some the packages in the tests plug-in around and removed the extensions that should not be required anymore. David, please take a look at the AllDiscoveryTestSuite. It seems that one of the tests currently expects a local site that is not present. We could host it at mylyn.eclipse.org if that would help to make the test pass.
(In reply to comment #5) > Added plug-ins to the Mylyn feature. I moved some the packages in the tests Thanks, that's great! > plug-in around and removed the extensions that should not be required anymore. What happened to BundleDiscoveryStategyTest? Those extensions _should_ be there and the test too. It's perfectly legitimate for installed bundles to contribute to the discovery UI. > David, please take a look at the AllDiscoveryTestSuite. It seems that one of the > tests currently expects a local site that is not present. We could host it at > mylyn.eclipse.org if that would help to make the test pass. Agreed, that's something that will need resolving.
> What happened to BundleDiscoveryStategyTest? Those extensions _should_ be there > and the test too. It's perfectly legitimate for installed bundles to contribute > to the discovery UI. The only thing I intended to remove was ShowConnectorDiscoveryWizardCommandHandler and the corresponding contribution in the plugin.xml since it seemed that this was not needed anymore. I don't see a BundleDiscoveryStategyTest class in the CVS history either or those contributions in the plugin.xml. In which package would that class be?
If I recall correctly the class was in @org.eclipse.mylyn.discovery.tests.core@ and the plugin.xml contained some extensions used by the test. Looking at the @plugin.xml@ in CVS (the deleted file) there appears to be no trace of the extensions... I must be dreaming.
I double checked the copy of the CVS repository that I created on Monday and couldn't find any extension of that sort in the test plug-in. Maybe a commit didn't complete fully.
Thanks for checking Steffen.... I'm not sure if I believe my eyes or my brain. Either way, I'm flabergasted.
