This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 275156 - EclipseLink should support complex PL/SQL arguments for Stored Functions
Summary: EclipseLink should support complex PL/SQL arguments for Stored Functions
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL: http://yuml.me/diagram/class/[Datasou...
Whiteboard:
Keywords:
Depends on:
Blocks: 297266
  Show dependency tree
 
Reported: 2009-05-06 10:18 EDT by Mike Norman CLA
Modified: 2022-06-09 10:20 EDT (History)
1 user (show)

See Also:


Attachments
adds plsql stored function support (57.91 KB, patch)
2011-03-08 11:02 EST, James Sutherland CLA
no flags Details | Diff
better refactor (34.49 KB, patch)
2011-03-17 11:15 EDT, Mike Norman CLA
no flags Details | Diff
stored function annotations/xml, multi cursors/result set, plsql xml (694.33 KB, patch)
2011-03-24 11:22 EDT, James Sutherland CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Norman CLA 2009-05-06 10:18:33 EDT
The class PLSQLStoredProcedureCall contains the support for using complex
PL/SQL types as arguments. However, due to how the class hierarchy is laided
out, StoredFunction call does not inherit any of the support for using complex
PL/SQL types as either arguments or as a return type.
Comment 1 Mike Norman CLA 2010-01-20 11:08:53 EST
Since this 'bug' is actually closer to a 'feature', change the target to 2.1
as we are past feature-complete date for 2.0.1

When work is finished in trunk, re-visit to see if time/effort/risk is
justified to port over to 2.0.n
Comment 2 James Sutherland CLA 2011-03-08 11:02:52 EST
Created attachment 190667 [details]
adds plsql stored function support
Comment 3 Mike Norman CLA 2011-03-17 11:15:49 EDT
Created attachment 191429 [details]
better refactor
Comment 4 James Sutherland CLA 2011-03-24 11:21:07 EDT
Not sure what to make of the "better refactor" patch??

The code seems much more complex then the previous.  If we really need for StoredFunctionCall and PLSQLFunctionCall to be castable, then an FunctionCall interface may be more useful than a PLSQLCall interface, (although I'm not sure what would be in the interface given they don't share any methods).  This would allow all of the PLSQL code to be shared instead of duplicated.
Comment 5 James Sutherland CLA 2011-03-24 11:22:13 EDT
Created attachment 191833 [details]
stored function annotations/xml, multi cursors/result set, plsql xml
Comment 6 James Sutherland CLA 2011-03-24 11:39:23 EDT
SVN trunk pending commit: bug#275156, 294772, 332221

 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=275156

 

Code review: Mike Norman (pending)

 

Changes:

- New tests in CustomSQLModel for cursors, result set and unnamed cursors

- Updated eclipselink-orm schema to be 2.3 and add name-stored-function-query, multiple-result-sets, call-by-index

- Updated NamedStoredProcedureQuery annotation to add multipleResultSets and callByIndex

- Added JPA meta-data processing for NamedStoredProcedureQuery annotations and xml.

- Update DatabaseAccessor, DatabaseCall, DatabasePlatform to refactor result set process to avoid code duplication and process multiple result sets/cursors

- Added legacy project.xml support for PLSQLStoredFunctionCall

- Fixed issue with MySQL and procedure calls without arguments.

- Fixed unnamed cursors in StoredProcedureCall

- Update legacy project.xml schema to be 2.3

- Added JPA tests for stored functions to AdvancedJPA test model
Comment 7 James Sutherland CLA 2011-05-03 13:09:16 EDT
checked in
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:20:44 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink