Community
Participate
Working Groups
Build ID: 3.5 M7 Steps To Reproduce: 1. Install org.eclipse.cdt.feature.group/5.0.1.200809120802 from http://download.eclipse.org/tools/cdt/releases/ganymede into a profile. 2. Leave the http site enabled in the profile 3. Launch the newly-created org.eclipse.equinox.p2.director app with the following arguments: -uninstallIU org.eclipse.cdt.feature.group -destination <profile_location> -profile SDKProfile More information: Because the http site is in the target's profile, it gets loaded and LatestIUVersionQuery returns version 5.0.2 of the UI. In this case since 5.0.2 wasn't installed, it reports success while leaving the 5.0.1 version installed. The search space for uninstalls should be limited to what is actually installed in a profile. This should be true even if a "-repository" argument is provided on the command line.
Created attachment 134136 [details] Return an empty Collector when collecting rootIUs for uninstall operations
Were you using the new director application or the old one?
The new one. The patch contains a test for the new application. I'll play with the tests some more. The parameters for the two apps are close enough that I think we can run both with the same input parameters, so we should update the tests to do that. This problem may exist in the older application as well. What made me find it with the new application is the fact that you can use it to do an update. With this patch, passing the parameters "-uninstallIU <my.iu> -installIU <my.iu> -repository <recently_updated_repo>" without any explicit versions will successfully update a profile to the latest version in the repo, no matter what what version is currently installed in the profile.
Created attachment 134575 [details] Patch for the DirectorApplication This patch contains a simplified version of Terrys patch. There's no need to call collectRootIUs at all when uninstalling since that method only acts on the provided repositories. The patch does not contain the tests.
Created attachment 134576 [details] Patch for the DirectorApplictionTest This patch contains Terrys test, now added to the DirectorApplicationTest (the test suite for the new director application).
Patch reviewed and released.
