Community
Participate
Working Groups
I20090430-2300 If edit a target on the "Definition" tab, then go to the "Content" tab and back to the "Definition" tab, I can no longer save. The editor remains dirty and I lose my changes. Using either Ctrl-S or the File > Save action has no effect.
I'm seeing the same behavior.
yap, me too. It's on the radar for RC1 ;)
Created attachment 134686 [details] Patch Not the most elegent solution, but less invasive. Let me know if you don't like the approach.
I agree that this is not the most elegant solution, but I wasn't able to come up with anything better. Ankur's solution is actually pretty similar to what the PDEEditor framework does, just in a simpler way (since we don't have multiple input contexts). The multi page editor framework is helpful enough to call commit() on a page when you switch to another one. This marks the page as no longer being dirty (i.e. it has saved back to the model). The editor's dirty state is intended to be separate from this (i.e. the model differs from the editor's file input). We do not currently do this check and instead want the editor to be dirty if you touch anything. Going forward we could consider other options that would check to see if the model's contents have actually changed from what's on disk. But for RC1, Ankur's fix is good. Darin, please verify.
Verified. Works + low risk.
