Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 274631 - [WorkingSets] Save/restore of aggregate workingset broken by changes from Bug 217955.
Summary: [WorkingSets] Save/restore of aggregate workingset broken by changes from Bug...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Hitesh CLA
QA Contact: Hitesh CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 194917
  Show dependency tree
 
Reported: 2009-05-01 05:52 EDT by Hitesh CLA
Modified: 2010-10-19 05:54 EDT (History)
3 users (show)

See Also:
francisu: review+

Attachments
save/restore test (6.03 KB, patch)
2009-05-01 05:52 EDT, Hitesh CLA 		no flags Details | Diff
Possible patch (1.34 KB, patch)
2009-05-01 05:56 EDT, Hitesh CLA 		emoffatt: iplog+
Details | Diff
Corrected Test (6.07 KB, patch)
2009-05-12 06:38 EDT, Hitesh CLA 		emoffatt: iplog+
Details | Diff
Fix For Test Failures v01 (2.07 KB, text/plain)
2010-10-19 05:54 EDT, Hitesh CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hitesh CLA 2009-05-01 05:52:02 EDT 
Created attachment 134046 [details]
save/restore test

Changes from the Bug 217955 have caused save/restore of aggregate workingsets to fail under certain conditions.This due to early restore and forward references in memento. See the attached test. 

I'll post a possible patch.
Comment 1 Hitesh CLA 2009-05-01 05:56:50 EDT 
Created attachment 134047 [details]
Possible patch

Francis, can you please review the attached patch, and confirm it does not affect the work from Bug 217955.
Comment 2 Hitesh CLA 2009-05-04 00:38:48 EDT 
Eric, I have a patch ready for Bug 194917 - the cycle avoidance at save/restore. But that fix depends on fixing this bug first.
Comment 3 Francis Upton IV CLA 2009-05-11 14:39:05 EDT 
This patch looks good, Eric, do you want me to check this in today so it gets into tonights build?
Comment 4 Eric Moffatt CLA 2009-05-11 15:57:48 EDT 
Sure, looks ok to me...
Comment 5 Francis Upton IV CLA 2009-05-11 16:48:49 EDT 
Hitesh, when running the full Platform UI tests, the following test case fails:

/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dynamicplugins/WorkingSetTests.java

The method testWorkingSetUpdater() fails because it's getting a  null event.

This only happens when the full UI tests are run; I have not investigated the cause of the failure (and the patch is probably fine), but I'm guessing that it might be that your test case causes a problem with this test if it's run later.

So I'm going to hold off on this until the tests are fixed, and also withdraw my +1 review.
Comment 6 Hitesh CLA 2009-05-12 06:38:03 EDT 
Created attachment 135320 [details]
Corrected Test

Thanks.
I have fixed the test.We are good to go.
Comment 7 Francis Upton IV CLA 2009-05-12 06:59:45 EDT 
Excellent, thanks for your hard work on this.  In the future, if you could run the *entire* UI test suite before submitting your patches it would be better.  Thanks again!

Released to HEAD, 3.5RC1, I20090512-2000.
Comment 8 Paul Webster CLA 2009-05-15 08:40:41 EDT 
To assign
Comment 9 Paul Webster CLA 2009-05-15 08:42:01 EDT 
assigned
Comment 10 Hitesh CLA 2010-10-19 05:54:22 EDT 
Created attachment 181162 [details]
Fix For Test Failures v01

Some changes in this area are causing the problem to re-occur (IAggregateWorkingSetTest) - I get a failure with latest code. I am releasing the attached which fixes the restore op of workingsets.