Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 274373 - [Metadata] Some testing data folders not parametrized
Summary: [Metadata] Some testing data folders not parametrized
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-29 14:46 EDT by Andrew Overholt CLA
Modified: 2009-06-03 13:58 EDT (History)
1 user (show)

See Also:
pwebster: review+
bokowski: review+


Attachments
patch (1.54 KB, patch)
2009-04-29 14:47 EDT, Andrew Overholt CLA
no flags Details | Diff
Automated UI tests run with the patch (300.38 KB, text/html)
2009-05-04 11:04 EDT, Paul Webster CLA
no flags Details
another patch (1.31 KB, patch)
2009-05-04 15:52 EDT, Andrew Overholt CLA
pwebster: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2009-04-29 14:46:42 EDT
parts-data-folder and session-data-folder aren't variables.  It would help our testing if they were.  I'll attach a patch.
Comment 1 Andrew Overholt CLA 2009-04-29 14:47:30 EDT
Created attachment 133814 [details]
patch

This patch turns this test folders into variables.
Comment 2 Paul Webster CLA 2009-05-04 11:04:33 EDT
Created attachment 134250 [details]
Automated UI tests run with the patch
Comment 3 Paul Webster CLA 2009-05-04 11:06:10 EDT
Boris, could I get your OK on this?

PW
Comment 4 Boris Bokowski CLA 2009-05-04 11:26:47 EDT
Sure! Just out of curiosity - how did you run our test suite locally?
Comment 5 Andrew Overholt CLA 2009-05-04 11:41:41 EDT
(In reply to comment #4)
> Sure! Just out of curiosity - how did you run our test suite locally?

I checked out the source of all of the Eclipse SDK tests, built it all, and ran it using the runtests script that is used during all of the builds.  I have a custom properties file to make the tests not try to write to the system-wide installation directory (not owned by the test runner).  I did all of the running in an Xvnc session.  I can provide more details if you'd like :)
Comment 6 Paul Webster CLA 2009-05-04 12:21:50 EDT
(In reply to comment #4)
> Sure! Just out of curiosity - how did you run our test suite locally?
> 

In the general case, you download the eclipse-Automated-Tests-I20090311-0100.zip, unzip it, and copy the matching eclipse-SDK-* into eclipse-testing/ directory.

Then run it with the appropriate parameters, in my case:
bash$ ./runtests -os linux -ws gtk -arch x86 ui

To test the patch I unzipped eclipse-junit-tests-I20090311-0100.zip, patched org.eclipse.ui.tests/test.xml and zipped it up again.

runtests takes care of extracting all of the bits that are needed.

PW
Comment 7 Andrew Overholt CLA 2009-05-04 12:41:34 EDT
Yeah, I was just saying how I do it to test our built RPMs.  What Paul says is how one would normally do it.
Comment 8 Boris Bokowski CLA 2009-05-04 12:47:34 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > Sure! Just out of curiosity - how did you run our test suite locally?
> 
> I checked out the source of all of the Eclipse SDK tests, built it all, and ran
> it using the runtests script that is used during all of the builds.  I have a
> custom properties file to make the tests not try to write to the system-wide
> installation directory (not owned by the test runner).  I did all of the
> running in an Xvnc session.  I can provide more details if you'd like :)

Sounds interesting... I would like to be able to run the UI tests from the command line, using the test.xml ant scripts, without having to download the full eclipse-Automated-Tests-xyz.zip. It sounds like what you are doing is close to my desired result; if I am right, could you maybe provide more details? A wiki page would be a good place for that information :-)
Comment 9 Paul Webster CLA 2009-05-04 13:06:38 EDT
Released >20090504
PW
Comment 10 Andrew Overholt CLA 2009-05-04 13:30:04 EDT
(In reply to comment #8)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Sure! Just out of curiosity - how did you run our test suite locally?
> >
> > I checked out the source of all of the Eclipse SDK tests, built it all, and
> ran
> > it using the runtests script that is used during all of the builds.  I have a
> > custom properties file to make the tests not try to write to the system-wide
> > installation directory (not owned by the test runner).  I did all of the
> > running in an Xvnc session.  I can provide more details if you'd like :)
> 
> Sounds interesting... I would like to be able to run the UI tests from the
> command line, using the test.xml ant scripts, without having to download the
> full eclipse-Automated-Tests-xyz.zip. It sounds like what you are doing is close
> to my desired result; if I am right, could you maybe provide more details? A
> wiki page would be a good place for that information :-)

I've added it to my todo list :)
Comment 11 Andrew Overholt CLA 2009-05-04 15:52:17 EDT
Created attachment 134297 [details]
another patch

My patch had a slight mistake in it.  I was using _ instead of - in the ant variable.  This patch fixes it and applies against head.  Sorry for the inconvenience and thanks for applying the first one.
Comment 12 Boris Bokowski CLA 2009-05-04 15:56:09 EDT
(In reply to comment #11)
> Created an attachment (id=134297) [details]
> another patch
> 
> My patch had a slight mistake in it.  I was using _ instead of - in the ant
> variable.  This patch fixes it and applies against head.  Sorry for the
> inconvenience and thanks for applying the first one.

We've added it to our todo list. :-P

Just kidding... released to HEAD. This was clearly a typo, which I should have caught as part of my review.
Comment 13 Paul Webster CLA 2009-05-15 09:33:00 EDT
Andrew, are you able to use the on of the latest eclipse-Automated-Tests-I20090514-2000.zip as you intended?

PW
Comment 14 Andrew Overholt CLA 2009-05-15 09:41:06 EDT
(In reply to comment #13)
> Andrew, are you able to use the on of the latest
> eclipse-Automated-Tests-I20090514-2000.zip as you intended?

I am not able to actually test it now but I verified that the relevant test.xml has the expected content.  Thanks.