Community
Participate
Working Groups
I20090428-0100. When having a multi-selection of children (not siblings) in the Call Hierarchy the behavior of 'Expand With Constructors' is wrong: it only applies it on the first selected item. Either we should not offer the action in this case or we apply the state to all selected elements, so that when I later expand one of the callers I get the constructors as well. NOTE: multi-selection on siblings works as expected.
I guess disabling is better and probably simpler at this point. Markus?
> I guess disabling is better and probably simpler at this point. I agree. Furthermore, I don't think anybody would miss the possibility to toggle a parent together with a child. If you toggle a parent, this indicates that you're not (primarily) interested in the direct callers, so why should you select one of them and then want to see its constructor calls?
>so why should you >select one of them and then want to see its constructor calls? Maybe because I have more than one root node expanded and then 'Select All' plus checking the pref is faster than selecting individual nodes. But as said in comment 1 I'm also for disabling ;-) Raksha, can you provide us with a patch today?
Created attachment 133738 [details] FIX The EWC action is now disabled for parent-child selection at any level. If any one of the selected elements is a parent/child of the other elements at any level , then the action is not added to the menu. Also cleaned up the code in ExpandWithConstructorsAction.getSelectedInputElements() and added the logic it to ExpandWithConstructorsAction.run().
Thanks, released to HEAD.
Verified in I20090429-1800.
