This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 273981 - P2 metadata file artifacts.xml contains build-time path
Summary: P2 metadata file artifacts.xml contains build-time path
Status: RESOLVED FIXED
Alias: None
Product: Babel
Classification: Technology
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Babel server inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 274025
Blocks:
  Show dependency tree
 
Reported: 2009-04-28 03:36 EDT by Sean Flanigan CLA
Modified: 2010-02-10 15:46 EST (History)
1 user (show)

See Also:


Attachments
Untested patch to use -artifactRepositoryName when generating p2 metadata (902 bytes, patch)
2009-04-28 03:36 EDT, Sean Flanigan CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Flanigan CLA 2009-04-28 03:36:46 EDT
Created attachment 133493 [details]
Untested patch to use -artifactRepositoryName when generating p2 metadata

Build ID: 3.5.0.v20090417091040

Steps To Reproduce:
1. Download http://download.eclipse.org/technology/babel/update-site/galileo/artifacts.jar (not working at present: see https://bugs.eclipse.org/bugs/show_bug.cgi?id=271845#c3 )
2. unzip -p artifacts.jar | grep babel-working
<repository name='file:/home/babel-working/live/output/galileo/ - artifacts' type='org.eclipse.equinox.p2.artifact.repository.simpleRepository' version='1'>



More information:
This is related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=266321 .  In Babel's case the P2 metadata generator is used, so we should just need the -artifactRepositoryName option: http://wiki.eclipse.org/Equinox_p2_Metadata_Generator#Arguments_describing_the_output

As far as I know, this hard-coded path should be benign, but it is ugly, and it could conceivably cause unwanted diffs in some situations (eg distro packaging).
Comment 1 Denis Roy CLA 2009-04-28 08:49:09 EDT
Thanks for the patch.  Right now I can't get p2 metadata to complete at all (see bug 274025).  If you have any insight, that would be most welcome.
Comment 2 Kit Lo CLA 2010-02-10 15:46:55 EST
"EclipseGenerator" is now deprecated. I switched to use "UpdateSitePublisher". I added the "metadataRepositoryName" and "artifactRepositoryName" while I was doing that.