Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 273936 - [ds tooling] editor fails when component has a factory id
Summary: [ds tooling] editor fails when component has a factory id
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-27 15:18 EDT by Bryan Hunt CLA
Modified: 2009-04-27 16:54 EDT (History)
2 users (show)

See Also:


Attachments
patch (953 bytes, patch)
2009-04-27 16:24 EDT, Benjamin Cabé CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Hunt CLA 2009-04-27 15:18:12 EDT
Build I20090427-0800

Create a service component
Give the component a Factory ID
Exit the editor
Double-click the component.xml file
The Overview and Services tabs will be empty.
Comment 1 Bryan Hunt CLA 2009-04-27 15:20:44 EDT
I've also seen cases where the text editor comes up instead of the component definition editor
Comment 2 Chris Aniszczyk CLA 2009-04-27 15:24:21 EDT
post your xml file here?
Comment 3 Bryan Hunt CLA 2009-04-27 15:25:48 EDT
<?xml version="1.0" encoding="UTF-8"?>
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" factory="hello.factory" name="hello" xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0">
   <implementation class="test.Hello"/>
   <service>
      <provide interface="test.IHello"/>
   </service>
</scr:component>
Comment 4 Chris Aniszczyk CLA 2009-04-27 15:28:27 EDT
well that's interesting, there's too scr namepsaces, remove one and you should be good. How did that happen?

<?xml version="1.0" encoding="UTF-8"?>
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0"
factory="hello.factory" name="hello">
   <implementation class="test.Hello"/>
   <service>
      <provide interface="test.IHello"/>
   </service>
</scr:component>
Comment 5 Bryan Hunt CLA 2009-04-27 15:41:35 EDT
The second namespace gets added when you set the factory id
Comment 6 Chris Aniszczyk CLA 2009-04-27 15:44:35 EDT
weird, I can't reproduce.

*boggles the mind*

will keep trying
Comment 7 Bryan Hunt CLA 2009-04-27 15:46:54 EDT
Hate it when that happens ... just to verify, you are using the Cocoa I-build from this morning?
Comment 8 Chris Aniszczyk CLA 2009-04-27 15:49:21 EDT
I am.

Although from the looks of it, it could be a low-level bug in PDE's text editing framework :/
Comment 9 Bryan Hunt CLA 2009-04-27 15:53:56 EDT
I was able to repo with a fresh workspace and a brand new project.
Comment 10 Bryan Hunt CLA 2009-04-27 15:56:26 EDT
Hmmm, maybe this makes a difference ... I have the Equinox N20090426-1232 build in my dropins folder
Comment 11 Benjamin Cabé CLA 2009-04-27 15:58:33 EDT
I can easily reproduce
I'm investigating
Comment 12 Benjamin Cabé CLA 2009-04-27 16:03:52 EDT
ok, got it!
incoming patch!
Comment 13 Benjamin Cabé CLA 2009-04-27 16:24:39 EDT
Created attachment 133447 [details]
patch

The "xmlns..." is actually parsed as an attribute... This is not totally incorrect, I believe, but it should just not be saved when serializing the document!

Note the support for namespaces is very crappy right now; see 264083.
Comment 14 Benjamin Cabé CLA 2009-04-27 16:25:06 EDT
go Chris!
Comment 15 Chris Aniszczyk CLA 2009-04-27 16:34:18 EDT
hack but works :)

Where's my EMF when I need it...
Comment 16 Chris Aniszczyk CLA 2009-04-27 16:53:40 EDT
done.

> 20090427

We will live with this hack for now.