Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 27372 - [navigation] matching bracket highlight: highlight both
Summary: [navigation] matching bracket highlight: highlight both
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.8 M6   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-29 03:45 EST by Lars Neidhold CLA
Modified: 2012-03-13 10:16 EDT (History)
3 users (show)

See Also:

Attachments
fix (1004 bytes, patch)
2012-02-06 11:29 EST, Deepak Azad CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Neidhold CLA 2002-11-29 03:45:53 EST 
It would be nice if not only one of the matching brackets is highlighted. I 
think it´s better to highlight both.
Comment 1 Kai-Uwe Maetzel CLA 2002-12-09 11:14:50 EST 
The bracket indication would then overlap with the cursor position which is 
especially distracting when writing.
Comment 2 Lars Neidhold CLA 2002-12-10 02:09:41 EST 
Yes, but only if you choose an intense color. With a light color there´s really 
no problem. Assumed that you dont use a frame around the letter but simply set 
another background color for the opening and closing bracket.
Comment 3 Dani Megert CLA 2011-12-12 08:34:33 EST 
Let's try this.
Comment 4 Raksha Vasisht CLA 2012-01-23 12:57:16 EST 
Moving to M6...
Comment 5 Deepak Azad CLA 2012-02-06 11:29:13 EST 
Created attachment 210599 [details]
fix

Dani, do we need anything else here?

- The current default highlight looks good to me when both brackets are highlighted.
- In any case, with bug 358347 we will add an annotation for brackets and as a result provide (more) options to configure the highlight.
Comment 6 Deepak Azad CLA 2012-02-06 11:31:55 EST 
MatchingCharacterPainter is in Platform.
Comment 7 Dani Megert CLA 2012-02-07 04:46:10 EST 
The code location is OK, but while testing it I didn't like it too much: the caret already denotes the source bracket.

We should make this optional, best along with the new preference for bug 366400.
Comment 8 Dani Megert CLA 2012-02-13 03:21:24 EST 
Fixed along with bug bug 366400.
Comment 9 Dani Megert CLA 2012-03-13 10:16:12 EDT 
Verified in I20120312-1800.