Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 273626 - [publisher] Missing plug-in information from feature metadata
Summary: [publisher] Missing plug-in information from feature metadata
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 274134 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-24 14:32 EDT by DJ Houghton CLA
Modified: 2009-04-29 12:03 EDT (History)
4 users (show)

See Also:

Attachments
patch (2.46 KB, patch)
2009-04-27 16:11 EDT, DJ Houghton CLA 		no flags Details | Diff
patch (12.07 KB, patch)
2009-04-29 12:03 EDT, DJ Houghton CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2009-04-24 14:32:07 EDT 
In MetadataGeneratorHelper#createFeatureJarIU we set a bunch of IU properties for things like the plug-in id to use for the feature branding, etc.

It seems like these properties have been lost when we moved to using the publisher. Now when we install a feature, the IU property doesn't exist so the feature isn't returned as a BundleGroup from the BundleGroupProvider APIs.
Comment 1 DJ Houghton CLA 2009-04-24 14:32:33 EDT 
Marking as 3.5 since this is a regression from previous behaviour.
Comment 2 DJ Houghton CLA 2009-04-27 16:11:40 EDT 
Created attachment 133443 [details]
patch

I believe we just have to add these properties on the IUs. The InstallFeatureAction in the Eclipse touchpoint is already looking for the properties so nothing has to change there.

Ian, does this look ok to you?
Comment 3 Ian Bull CLA 2009-04-28 02:23:58 EDT 
It looks reasonable, although I think we need to consider translations especially for the description field.

Also, we seem to write these properties (look at FeaturesAction#createGroupIU), but they are created on the GroupIU instead of the FeatureJar.
Comment 4 Susan McCourt CLA 2009-04-29 11:13:22 EDT 
*** Bug 274134 has been marked as a duplicate of this bug. ***
Comment 5 Susan McCourt CLA 2009-04-29 11:37:16 EDT 
I think bug 273641 is another symptom of this, but I haven't looked into yet.
Comment 6 DJ Houghton CLA 2009-04-29 12:03:30 EDT 
Created attachment 133786 [details]
patch

I have released this updated patch. I removed the duplicate properties that are already being set in the other method, good catch Ian. 

I have tested against a local site and the features show up in the Features tab of the About dialog. The metadata for the site needs to be generated with the patch so (for instance) the Mylyn features will appear once a new build happens and the new properties are in the metadata.
Comment 7 DJ Houghton CLA 2009-04-29 12:03:59 EDT 
Closing.