Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 273559 - DirectorAppTest passes invalid options to the application
Summary: DirectorAppTest passes invalid options to the application
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 268194
  Show dependency tree
 
Reported: 2009-04-24 04:28 EDT by Thomas Hallgren CLA
Modified: 2009-04-24 11:08 EDT (History)
1 user (show)

See Also:

Attachments
Patch that removes the redundant options (3.73 KB, patch)
2009-04-24 04:30 EDT, Thomas Hallgren CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2009-04-24 04:28:02 EDT 
The DirectorAppTest is passing -vmargs ... options directly to the DirectorApp application. In real life, this will never happen since -vmargs are consumed by the launcher. Passing them is also completely redundant since nobody will act on them in the test since the launcher is never involved.
Comment 1 Thomas Hallgren CLA 2009-04-24 04:30:10 EDT 
Created attachment 133077 [details]
Patch that removes the redundant options

I'm implementing a more stringent check for the command line options now that complains about things that are not recognized. This change is needed to make the tests run correctly.
Comment 2 John Arthorne CLA 2009-04-24 10:10:25 EDT 
I can review this.
Comment 3 John Arthorne CLA 2009-04-24 10:23:00 EDT 
Fixed in HEAD.
Comment 4 Andrew Niefer CLA 2009-04-24 11:05:56 EDT 
To clarify slightly, the native executable does pass the -vmargs to eclipse.  They are stripped off by main and set on the system property "eclipse.vmargs".  The remainder of the arguments are then passed on to the framework.
Comment 5 John Arthorne CLA 2009-04-24 11:08:15 EDT 
Yes, but in this case the test is passing the arguments directly to an application's run method. In normal launching the vm args aren't passed to the application.