Description Oleg Vazhnev 2009-04-22 18:16:26 EDT

In many places such code can be found:

ModelHelper.getBPELEditor(getModel()).isHorizontalLayout()

For example, this line can be found in
- IfEditPart
- InvokeEditPart
- acctually any EditPart :)
- LeafBorder

This can result in NPE because bpelEditor can be null.
We can create EditParts inside other than BPELEditor window (for example inside 'Compare' window)

EditParts should not assume that they are created inside BPELEditor, they should not assume that BPELEditor exist.

Without fixing that it is not possible to implement some features, like 'Visual Compare of BPEL files'.

The fix could be very simple:

public boolean isHorizontalLayout(EObject model) {
    BPELEditor bpelEditor = ModelHelper.getBPELEditor(getModel());
    if (bpelEditor != null) {
        return bpelEditor.isHorizontalLayout();
    } else {
        return false;
    }
}