Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 273121 - Test launch fails if user selects to overwrite existing test log, but has existing test log open in editor
Summary: Test launch fails if user selects to overwrite existing test log, but has exi...
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Joe Toomey CLA
QA Contact:
URL:
Whiteboard: adopter
Keywords:
Depends on:
Blocks: 158284
  Show dependency tree
 
Reported: 2009-04-21 15:10 EDT by Joe Toomey CLA
Modified: 2016-05-05 11:05 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Toomey CLA 2009-04-21 15:10:04 EDT 
Test launch fails if user selects to overwrite existing test log, but has existing test log open in editor.

This defect was fixed in an inappropriate way in a copy of the models plugin, but it introduces an unacceptable dependency from org.eclipse.tptp.platform.models to org.eclipse.ui.  The correct place to perform the check to see if the existing file is open (and if so close it) is in the UI portion of the launch code.

I'll submit a patch in the next day or two.
Comment 1 Paul Slauenwhite CLA 2009-04-22 06:46:29 EDT 
Joe: What is the sizing for this defect?
Comment 2 Paul Slauenwhite CLA 2009-04-27 08:51:40 EDT 
Deferring to TPTP 4.6 as requested by Joe.

Joe,

Please attached the patch for this defect before May 15, 2009 (see http://www.eclipse.org/tptp/home/project_info/releaseinfo/4.6/schedule.html) and request review by Eugene and myself.  Also, what is the sizing for this defect?
Comment 3 Joe Toomey CLA 2009-05-13 11:53:35 EDT 
This defect is being fixed within the consuming product, so the severity is no longer major.  Reducing severity to normal.  Adding sizing.

I will not have the cycles to create and test a patch for this problem before May 15th, so I propose to defer the defect post 4.6.  After a fix has been delivered in the consuming product, I will update this defect with a patch suitable for post 4.6 use.
Comment 4 Paul Slauenwhite CLA 2009-05-27 10:21:24 EDT 
Approved by the PMC to defer to TPTP 4.6.1.
Comment 5 Ben Chen CLA 2009-06-29 13:32:05 EDT 
Problem is that if test log is in its editor and user tries to run the same test and overwrite the test log, the test execution seem to "pass" but the test log disappear in the TN, if you open the test log in java prospective, An error is displayed in the editor saying :Could not open the editor: Invalid editor input.

So still reproducible in TPTP-4.6.0-200906191311
Comment 6 Paul Slauenwhite CLA 2009-09-28 11:04:51 EDT 
Joe, any update on the status of this patch?
Comment 7 Paul Slauenwhite CLA 2009-12-14 14:57:35 EST 
Still a valid scenario for the consuming product but a lower priority.
Comment 8 Paul Slauenwhite CLA 2009-12-14 15:02:54 EST 
Deferring to TPTP 4.7.0.
Comment 9 Joe Toomey CLA 2010-02-08 15:28:51 EST 
I'm closing this defect as WONTFIX.  The consuming product that filed the issue is not requesting a fix at this point, and it's so far down on my TODO list that I'm certain I won't fix it for 4.7.0.  Rather than continuing to defer it from release to release, I am closing and if someone feels it's higher than a P3 normal, they can reopen and we can discuss resources to fix it.