Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 272974 - [Help] 'Content' preference page 'Restore Defaults' button clears out infocenter list regardless of defaults
Summary: [Help] 'Content' preference page 'Restore Defaults' button clears out infocen...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Austin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-20 16:21 EDT by Chris Austin CLA
Modified: 2009-04-20 17:50 EDT (History)
1 user (show)

See Also:


Attachments
Initial fix implementation (8.32 KB, patch)
2009-04-20 16:21 EDT, Chris Austin CLA
cgold: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Austin CLA 2009-04-20 16:21:54 EDT
Created attachment 132490 [details]
Initial fix implementation

Build ID: Version: 3.4.1 Build id: M20080911-1700

Steps To Reproduce:
Unfortunately, the only way to see this bug is to have an IBM product that uses the preference harvester installed.

1. Install and run RAD.  Open Preferences -> Help -> Content
Note the infocenters prepopulated.
2. Press the 'Restore Defaults' button.
Note that although you have made no changes, the list is now cleared.
Also note that the checkbox does not change, whether it is enabled or disabled when 'Restore Defaults' is pressed.


More information:
This should be remedied by querying the preferences Default Scope to return the list to its default state.  Thus, a plugin that needs to change the list, can set the defaults as well - ensuring the list is recoverable during the 'Restore Defaults' operation.

I have created a patch that fixes this issue, attached.
Comment 1 Chris Goldthorpe CLA 2009-04-20 17:36:18 EDT
Actually it can be reproduced if you add these values to pluginCustomization.ini

org.eclipse.help.base/remoteHelpName = eclipse
org.eclipse.help.base/remoteHelpPort = 80
org.eclipse.help.base/remoteHelpPath = help
org.eclipse.help.base/remoteHelpHost = www.eclipse.org
org.eclipse.help.base/remoteHelpICEnabled = true
org.eclipse.help.base/remoteHelpOn = true

The current way the Restore Defaults button works is incorrect and this is a needed fix.
Comment 2 Chris Goldthorpe CLA 2009-04-20 17:50:06 EDT
Patch committed to HEAD.