Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 272654 - [Manifest][Editors] Select all text in "name" after creating new attribute or element
Summary: [Manifest][Editors] Select all text in "name" after creating new attribute or...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-17 04:16 EDT by Philipp Kursawe CLA
Modified: 2009-07-30 11:34 EDT (History)
3 users (show)

See Also:


Attachments
Initial patch (756 bytes, patch)
2009-04-24 06:39 EDT, Philipp Kursawe CLA
contact: iplog+
Details | Diff
mylyn/context/zip (4.49 KB, application/octet-stream)
2009-04-24 06:39 EDT, Philipp Kursawe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Kursawe CLA 2009-04-17 04:16:52 EDT
Currently the editor only sets the focus to the name field after you created a new element or name. It should select the text in the name field so overwriting it is quicker possible.
I could provide a patch.
Comment 1 Chris Aniszczyk CLA 2009-04-17 11:32:35 EDT
patches are always nice :)
Comment 2 Philipp Kursawe CLA 2009-04-24 06:39:06 EDT
Created attachment 133093 [details]
Initial patch

enabled selection on all FormEntry text fields inside the focus listener. Works in my tests as expected.
Comment 3 Philipp Kursawe CLA 2009-04-24 06:39:14 EDT
Created attachment 133094 [details]
mylyn/context/zip
Comment 4 Curtis Windatt CLA 2009-04-29 10:58:45 EDT
It's getting pretty late in the cycle for patches, but we'll look at this in RC1.
Comment 5 Curtis Windatt CLA 2009-05-05 15:15:13 EDT
Moving to 3.6.  Very late in the cycle and there are higher priority items.
Comment 6 Benjamin Cabé CLA 2009-06-24 12:04:26 EDT
Phil, I'm not 100% sure I'm understanding what behaviour you wanna have. On my machine (WinXP), when I add an element to an extension, no field actually gets focused. Thus, I think I don't really understand what you mean by 

> Currently the editor only sets the focus to the name field after you created a
> new element or name.

The patch is cool anyways (one can type/overwrite data more easily), I'm just not sure it is really fixing what you're expecting
Comment 7 Philipp Kursawe CLA 2009-06-25 10:32:34 EDT
it works exactly like I wanted it to work now with the patch. If you like it too, you can update it to HEAD :)
Comment 8 Curtis Windatt CLA 2009-07-30 11:20:09 EDT
Ben, are you happy enough with the patch to put it in for M1 or would you like to see changes?
Comment 9 Benjamin Cabé CLA 2009-07-30 11:34:44 EDT
yup, released!