272517 – dd node is not externalized in Java EE 5.0

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 272517 - dd node is not externalized in Java EE 5.0

Summary: dd node is not externalized in Java EE 5.0

Status:	RESOLVED FIXED

Alias:	None

Product:	WTP Java EE Tools
Classification:	WebTools
Component:	jst.j2ee (show other bugs)
Version:	3.0.4
Hardware:	PC Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	3.1 M7
Assignee:	Petya Sabeva
QA Contact:	Chuck Bridgham

URL:
Whiteboard:	PMC_approved
Keywords:

Depends on:
Blocks:

Reported:	2009-04-16 11:15 EDT by Dimitar Giormov
Modified:	2013-05-27 10:13 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	dimitar.giormov: pmc_approved? (david_williams) dimitar.giormov: pmc_approved? (raghunathan.srinivasan) dimitar.giormov: pmc_approved? (naci.dai) dimitar.giormov: pmc_approved? (deboer) dimitar.giormov: pmc_approved? (neil.hauge) kaloyan: pmc_approved+

Attachments
ear DD node (22.05 KB, image/tiff) 2009-04-16 11:15 EDT, Dimitar Giormov	no flags	Details
Externalized DD Tree (3.70 KB, patch) 2009-04-27 03:29 EDT, Petya Sabeva	no flags	Details \| Diff
Externalized DD Tree Node (2.88 KB, patch) 2009-04-27 03:37 EDT, Petya Sabeva	no flags	Details \| Diff
refined (875 bytes, patch) 2009-04-27 04:09 EDT, Dimitar Giormov	no flags	Details \| Diff
patch (6.64 KB, patch) 2009-04-27 06:22 EDT, Petya Sabeva	no flags	Details \| Diff
patch (7.06 KB, patch) 2009-04-27 06:56 EDT, Petya Sabeva	kaloyan: iplog+	Details \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dimitar Giormov

2009-04-16 11:15:12 EDT

Created attachment 132090 [details]
ear DD node

see the screenshot.
Deployment Descriptor root node is not externalized.

Comment 1 Petya Sabeva

2009-04-27 03:29:19 EDT

Created attachment 133299 [details]
Externalized DD Tree

Comment 2 Petya Sabeva

2009-04-27 03:37:59 EDT

Created attachment 133301 [details]
Externalized DD Tree Node

In the previous patch, there were changes not applicable to this issue.

Comment 3 Dimitar Giormov

2009-04-27 04:09:19 EDT

Created attachment 133305 [details]
refined

Comment 4 Dimitar Giormov

2009-04-27 04:22:10 EDT

PMC Review requested due to UI change

In short every "Deployment Descriptor" node is externalized, except for EAR 5.0 projects. The fix is simply externalizes the EAR DD node.

Comment 5 Kaloyan Raev

2009-04-27 06:00:35 EDT

The suggested approach for label externalization does not seems to be the best one. Concatenation of externalized string with a dynamic value can cause problems in some languages when the label is later localized. Instead labels should be externalized with parameters, i.e. "Deployment Descriptor: {0}".

Comment 6 Petya Sabeva

2009-04-27 06:22:55 EDT

Created attachment 133334 [details]
patch

I have change the value of Messeges.DEPLOYMENT_DESCRIPTOR to "Deployment Descriptor: {0}".

Comment 7 Kaloyan Raev

2009-04-27 06:50:31 EDT

Petya, this is much better. 
One last comment from my side. You should use NLS.bind() instead of MessageFormat.format(). Although the result may look the same, NLS.bind() contains some additional error handling that fits better to the Eclipse environment.

Comment 8 Petya Sabeva

2009-04-27 06:56:11 EDT

Created attachment 133338 [details]
patch

I've changed MessageFormat.format() to NLS.bind().

Comment 9 Kaloyan Raev

2009-04-27 07:54:58 EDT

This is OK now.

Comment 10 Dimitar Giormov

2009-04-27 10:30:40 EDT

committed and released in head.