Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 271447 - [ui] Bad layout in 'Install available software' dialog
Summary: [ui] Bad layout in 'Install available software' dialog
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-07 08:54 EDT by Yury Chernikov CLA
Modified: 2009-04-16 17:40 EDT (History)
1 user (show)

See Also:

Attachments
patch (5.19 KB, patch)
2009-04-07 08:54 EDT, Yury Chernikov CLA 		susan: iplog+
Details | Diff
screenshot of Install new software dialog (44.16 KB, image/png)
2009-04-07 08:56 EDT, Yury Chernikov CLA 		no flags Details
screenshot of Add site dialog (11.01 KB, image/png)
2009-04-07 08:56 EDT, Yury Chernikov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Chernikov CLA 2009-04-07 08:54:37 EDT 
Created attachment 131119 [details]
patch

Build ID: I20090313-0100

Steps To Reproduce:
1. Open Help -> Install new software dialog 
Combobox with repositories has invalid layout (vertical fill).
See screenshot.

2. Press on Add button.
Buttons in Add Site dialog have unnecessary indent. See at attached screenshot.

Attached patch contains changes in AddRepositoryDialog (for item #1) and RepositorySelectionGroup (for item #2)
Comment 1 Yury Chernikov CLA 2009-04-07 08:56:00 EDT 
Created attachment 131121 [details]
screenshot of Install new software dialog
Comment 2 Yury Chernikov CLA 2009-04-07 08:56:41 EDT 
Created attachment 131122 [details]
screenshot of Add site dialog
Comment 3 Susan McCourt CLA 2009-04-07 10:55:50 EDT 
thanks for patches, marking 3.5
Comment 4 Susan McCourt CLA 2009-04-16 17:39:46 EDT 
Fixed in HEAD >20090416.
- The add site button alignment issue was already fixed in bug 268002.
- Applied the layout patch for centering the repo combo vertically.
- Also added code to ensure the minimum button width is honored for the repo combo's adjacent "Add..." button.
Comment 5 Susan McCourt CLA 2009-04-16 17:40:07 EDT 
Comment on attachment 131119 [details]
patch

applied RepositorySelectionGroup patch