Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 271162 - Eclipselink is hanging onto old units of work
Summary: Eclipselink is hanging onto old units of work
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-03 13:44 EDT by Lindsay Sutherland CLA
Modified: 2022-06-09 10:28 EDT (History)
3 users (show)

See Also:
peter.krogh: iplog+


Attachments
please see README.txt in zip root (7.39 MB, application/x-zip-compressed)
2009-04-03 13:47 EDT, Lindsay Sutherland CLA
no flags Details
proposed patch (138.31 KB, text/plain)
2009-04-24 14:39 EDT, Andrei Ilitchev CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lindsay Sutherland CLA 2009-04-03 13:44:36 EDT
Build ID:  M20080911-1700

Steps To Reproduce:
Run Provided MyTestSuite.java


More information:
This issue was originally filed as a metalink sr #6705142.993. The issue was fixed for Toplink v.10x.

If required, I can copy the original sr request if you cannot access it directly.
Comment 1 Lindsay Sutherland CLA 2009-04-03 13:47:30 EDT
Created attachment 130867 [details]
please see README.txt in zip root
Comment 2 Peter Krogh CLA 2009-04-08 11:51:43 EDT
I looked into this bug from the referenced metalink support case.

All the changes made at that time appear to be in EclipseLink.

Please run on the latest nightly on 1.1 and see if you can reproduce.

Also, to debug I put together a version of ExpressionBuilder that included an Exception dump in setSession().  Like this:

    public void setSession(Session session) {
		if (session instanceof UnitOfWork)
		{
			new RuntimeException("Unit Of Work set on the ExpressionBuilder").printStackTrace();
		}
        this.session = session;
    }

You can try that and see if you get any exceptions.
Comment 3 Lindsay Sutherland CLA 2009-04-08 18:23:16 EDT
Hi Peter,
thanks for looking into this.

I grabbed the latest nightly build but still see the same error as previously described.

Thanks


(In reply to comment #2)
> I looked into this bug from the referenced metalink support case.
> 
> All the changes made at that time appear to be in EclipseLink.
> 
> Please run on the latest nightly on 1.1 and see if you can reproduce.
> 
> Also, to debug I put together a version of ExpressionBuilder that included an
> Exception dump in setSession().  Like this:
> 
>     public void setSession(Session session) {
>                 if (session instanceof UnitOfWork)
>                 {
>                         new RuntimeException("Unit Of Work set on the
> ExpressionBuilder").printStackTrace();
>                 }
>         this.session = session;
>     }
> 
> You can try that and see if you get any exceptions.
> 

Comment 4 Lindsay Sutherland CLA 2009-04-16 11:33:56 EDT
Hi Peter,
I had no success running the MyTestSuite tests (included in the attachment with a README.txt file) with the latest nightly build from Monday night.

Did you have success running our tests?

I'm feeling under the gun here. I'm about two weeks away from a "go/no go" decision about upgrading to Eclipselink. Currently, we are in the "no go" status for our upcoming major release.

Thanks.




(In reply to comment #3)
> Hi Peter,
> thanks for looking into this.
> 
> I grabbed the latest nightly build but still see the same error as previously
> described.
> 
> Thanks
> 
> 
> (In reply to comment #2)
> > I looked into this bug from the referenced metalink support case.
> > 
> > All the changes made at that time appear to be in EclipseLink.
> > 
> > Please run on the latest nightly on 1.1 and see if you can reproduce.
> > 
> > Also, to debug I put together a version of ExpressionBuilder that included an
> > Exception dump in setSession().  Like this:
> > 
> >     public void setSession(Session session) {
> >                 if (session instanceof UnitOfWork)
> >                 {
> >                         new RuntimeException("Unit Of Work set on the
> > ExpressionBuilder").printStackTrace();
> >                 }
> >         this.session = session;
> >     }
> > 
> > You can try that and see if you get any exceptions.
> > 
> 

Comment 5 Peter Krogh CLA 2009-04-21 16:30:54 EDT
Please try the debug work around I suggested.  It will tell you if this is the same issue as earlier or not.

I have also built and send you by email a debug version of the jar.
Comment 6 Andrei Ilitchev CLA 2009-04-24 14:39:24 EDT
Created attachment 133161 [details]
proposed patch
Comment 7 Andrei Ilitchev CLA 2009-04-24 15:16:32 EDT
Checked in the patch suggested by Lindsay into both 1.1.1 and trunk.
Reviewed by Peter.
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:28:40 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink